Repository navigation
Ship a fix only on the platforms it fixes; 1.4.1 is Windows-only - #51
Merged
Merged
Conversation
MAJOR.MINOR is the product, the same features on all three platforms; a fix release (x.y.z) now ships only where something changed, so iPhone testers are not sent a build with nothing in it. The patch counter stays shared, so every number is one release. - prepare-release.ps1 -Platforms writes RELEASE-PLATFORMS, refuses a partial feature release, and moves the iOS marketing version only when iOS ships. - build/release-platforms.sh reads it: each release workflow's first job skips the platform if it is not listed, and release.yml's notes job creates the draft and opens it with "RSS Quick 1.4.1 is a Windows-only release...". - ReleaseCheck, on Windows and the Mac, reads the recent releases and takes the newest one carrying its own download, so a later release for another platform never hides one meant for this copy. Matching tests on both sides. - WORKFLOW.md, CLAUDE.md and the 1.4.1 changelog say so. 1.4.1 is Windows only, and the iOS project goes back to 1.4.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Swift tests: labelled arguments in declaration order (page before otherAsset), which broke the required macOS check. - The draft is created only if none exists, with gh, so re-running the notes job or re-tagging cannot append the generated notes twice or replace edits. An iPhone-only fix makes no GitHub release; it would have nothing to download. - A manual run on a v* tag follows RELEASE-PLATFORMS, so redoing a release cannot add a platform it left out. - The update checks fetch 10 releases, not 30 (each entry is ~36 KB). - prepare-release.ps1 accepts windows,macos through powershell -File. - The notes say the iPhone and iPad version comes through TestFlight. - Tests use /releases and cover an empty list on both sides; the iOS and macOS READMEs and WORKFLOW.md describe the new process, including unticking Set as the latest release for a release with no Windows files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kelly's amendment to "one feature set, three versions": it isn't responsible to send iPhone testers a new build with nothing in it. MAJOR.MINOR is the product (the same features on all three platforms). A fix release ships only where something changed, and the release notes say so.
The rule (WORKFLOW.md, Versioning)
prepare-release.ps1refuses a partial one.How
build/prepare-release.ps1 1.4.1 -Platforms windowswritesRELEASE-PLATFORMS, and moves the iOS marketing version only when iOS ships.build/release-platforms.shreads it. Each release workflow's first job skips its platform if it isn't listed.release.yml's newnotesjob creates the draft on every tag and opens it with "RSS Quick 1.4.1 is a Windows-only release. The Mac, iPhone and iPad versions have not changed, so there is nothing new to install there." It used to be the Windows job that made the draft, so a Mac-only fix would have had no notes.ReleaseCheck(Windows portable copy and the Mac) reads/releases?per_page=30and takes the newest release carrying its own download. Looking only at/releases/latest, a Windows-only 1.4.3 published after a Mac-only 1.4.2 would hide 1.4.2 from every Mac on 1.4.0. Matching tests on both sides. Velopack, the installed Windows copy's updater, already looks for the newest release with its feed files.RELEASE-PLATFORMS=windows, the CHANGELOG heading says so, and the iOS project goes back to 1.4.0.release-platforms.shwas checked by hand for every combination of platforms, an empty file and an unknown word. The Swift changes were written without a Swift toolchain, soapple-ciis their first compile.🤖 Generated with Claude Code