Skip to content

Post-merge cleanup: dependency bot model pin, Mac Catalyst 17.0 for the MAUI libraries - #50

Merged
michaelstonis merged 3 commits into
developfrom
chore/post-merge-cleanup
Oct 2, 2026
Merged

michaelstonis merged 3 commits into
developfrom
chore/post-merge-cleanup

Conversation

@michaelstonis

Copy link
Copy Markdown
Contributor

What

Verification

  • gh aw compile: 0 errors, 0 warnings.
  • The bot fix itself can only be verified by running the workflow after merge.
  • MAUI library builds are verified by this PR's CI (no MAUI workload locally).

🤖 Generated with Claude Code

michaelstonis and others added 3 commits October 2, 2026 16:21
…s rules

The compiled default model, claude-sonnet-4.6, is no longer offered to the
Copilot CLI, so every weekly run since 2026-08-31 failed with a 400.

The Avalonia 11.3 rule is replaced: the repo is on Avalonia 12 without
Avalonia.ReactiveUI. New rules hold ReactiveUI on 24.x and keep the
packages it requires in step, which is what broke restore in #49.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The Xcode 27 SDK rejects app heads below Mac Catalyst 17.0, so no app
built with the current workload can target the 15.0 the libraries declared.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 2, 2026 21:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The SourceGenerators rule lacks a valid version boundary, and the review record uses a future timestamp.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Updates dependency automation and aligns MAUI libraries with Xcode 27 requirements.

Changes:

  • Pins the dependency bot to claude-sonnet-5 and updates its rules.
  • Raises Mac Catalyst minimum support to 17.0.
  • Adds the October 2 PR review record.
File Description
.github/​workflows/​dependency-update.md Updates model and dependency rules.
.github/​workflows/​dependency-update.lock.yml Regenerates the compiled workflow.
Stellar.Maui/​Stellar.Maui.csproj Raises Mac Catalyst minimum to 17.0.
Stellar.Maui.PopUp/​Stellar.Maui.PopUp.csproj Raises Mac Catalyst minimum to 17.0.
pr-review-2026-10-02.md Records recent PR review findings.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +69 to +72
**Keep ReactiveUI on the 24.x line.** This covers every `ReactiveUI.*.Reactive`
package and `ReactiveUI.SourceGenerators`. ReactiveUI 25 moves binding onto a
source generator: `Bind` calls through private view fields, which is how Stellar
views are written, get no generated binding and throw at run time, and the
@michaelstonis
michaelstonis merged commit b73c2a4 into develop Oct 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants