Repository navigation
Include the released DMTCP fetcher in runtime image builds - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime image builds failed because the Docker context excluded the new DMTCP release fetcher. Include it, and explicitly install libatomic1 alongside libstdc++6: a clean Debian smoke build exposed this additional native dependency. The regular CI now builds and executes the actual DMTCP Docker stage using a small pinned Debian base.
The manual image workflow applies these packaging fixes when checking out the already-published v2.0.0-beta.17 tag. The tag, CLI source and all released binary assets remain immutable. Future release tags carry the corrected Dockerfile and context directly. README, DMTCP docs and release instructions name the required system libraries.
Validation: actionlint, diff checks and the clean Debian Docker-stage test pass. All CI checks pass. Both complete vLLM runtime images were built, passed native program/plugin checks through tini (follow-up PR #66), and were published by runs 41330315791 and 41330318667.