Repository navigation
test(reports): cover rejected session-start pushes - #1348
Merged
jeff-r2026 merged 1 commit intoOct 23, 2026
Merged
Conversation
Signed-off-by: ydflow <314143294+ydflow@users.noreply.github.com>
|
No findings in the specified diff. This is a tests-only change, so no end-to-end record is required under the review rules. The PR description nevertheless documents a representative real-CLI run with retries disabled: 3 passed, including the new rejection/retry case. The documented testing is sufficient. Review was read-only; I did not run, build, or install anything from the PR. |
This was referenced Oct 23, 2026
jeff-r2026
approved these changes
Oct 23, 2026
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the rejected-push regression requested in the #1324 review, on top of the merged #1323 fix. The existing SessionStart case covers a slow successful push; this case verifies that a delayed rejection retains unacknowledged usage and session snapshots, releases both report and sync locks, and later publishes exactly once when the remote accepts writes.
Tests only: one E2E file, using its existing real-CLI SessionStart helper. The local bare remote delays its first rejection by seven seconds, exceeding pull's five-second wait; subsequent writes reject immediately so the case does not spend seven seconds on every report category. All original receiver modes keep their behavior.
Type of Change
Test Plan
npm run buildnpx tsc --noEmitnpm run lintgit diff --checknpx vitest run --config vitest.e2e.config.ts src/__tests__/e2e/report-timeout.test.ts -t 'session-start|retains a rejected report' --maxWorkers=1 --retry=03 passed, 18 not selected: the existing direct-pull rejection/retry case, existing slow SessionStart success case, and new slow SessionStart rejection/retry case. The new case completed in about 26 seconds locally under the unchanged 60-second test deadline.
Before narrowing the fixture delay to the first rejection, the broader selection including
git/claudeslow direct-pull also passed (4 cases). That first version delayed every rejected report write and took about 54 seconds for the new case; the final fixture preserves the same data/lock/retry assertions with less idle waiting.Windows / Node 24, Claude + generic Git provider, real CLI and Git subprocesses against an isolated local bare remote. No remote credentials or model calls. The full provider/agent matrix and complete unit suite were not run locally for this test-only change.
Related Issues
Follow-up to #1323 and #1322; extracts the failure-path test from #1324. The runtime fix is already in main through #1323. This PR adds regression coverage for its rejected-push path.