Repository navigation
Conversation
Tencent#1210 pinned the POSIX `bash -lc` rendering in codex-team-hooks.test.ts, and Tencent#1221 put that file on the Windows test list. On Windows the command renders the Git Bash path, and the Windows list guard rejects a pinned POSIX rendering in a file that does not pin the platform. Every Lint & Test leg and the Windows job on main fail.
Collaborator
Author
|
Folded into #1283. |
|
No findings in the specified PR diff. The change is tests-only, and the PR description documents 31 passing targeted tests plus clean type-check and lint results. No real-CLI verification record is required. Review was read-only; I did not run, build, or install anything from the PR. |
Collaborator
Author
|
Superseded by #1287, which fixes the cause in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
describe('reconcileCodexDispatchers — the Windows override keeps the block contract (#1209)') beforeEach + pin process.platform to linux, reset the shell cache afterEach + reset the shell cache, restore mocks#1210 pinned the POSIX
bash -lcrendering incodex-team-hooks.test.ts. #1221 put that file on the Windows test list. The two landed separately, somainis red:windows-test-list.test.ts: a pinned POSIX rendering needs a pinned platform."C:/Program Files/Git/bin/bash.exe" -lc ....Evidence
mainat d9d0e0f, run 39734895938:Tests 1 failed | 11978 passed,codex-team-hooks.test.ts has no POSIX-only construct.After:
npx vitest run src/__tests__/codex-team-hooks.test.ts src/__tests__/windows-test-list.test.ts: 31 passed.tsc --noEmitandnpm run lintare clean.Tests-only change, so no real-CLI record.
Merge Danger
Door: two-way
Blast Radius: test-only