Repository navigation
Show only the top 10 promoters with downloads on the leaderboard - #183
Merged
Merged
Conversation
A quiet window listed every approved promoter, most at 0 downloads and all tied for second place. The board now shows the top 10 with at least one download, and always keeps the viewer's own row.
Deploying palestine-pfp-maker with
|
| Latest commit: |
999698a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a40fa146.palestine-pfp-maker.pages.dev |
| Branch Preview URL: | https://leaderboard-top-10.palestine-pfp-maker.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The leaderboard listed every approved promoter in every window. Most have 0 downloads, and because equal counts share a rank, everyone behind first place showed up tied at 🥈. On https://ppm.techforpalestine.org/leaderboard that was 14 rows of zeros under one real entry.
What
Tests
e2e/leaderboard.spec.tspasses on Chromium (12/12). Firefox and WebKit were not run locally; CI covers them.