Repository navigation
Add option to turn off the GX worker thread - #548
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Register the GX worker setting WheelWizard/Features/Settings/ISettingsServices.cs, WheelWizard/Features/Settings/SettingsManager.cs |
The settings interface and manager expose RECOMP_GX_WORKER. The manager registers video.gx_worker with a default value of true. |
Connect the GX worker switch WheelWizard/Features/Settings/Views/RecompSettings.axaml, WheelWizard/Features/Settings/Views/RecompSettings.axaml.cs, WheelWizard/Resources/Languages/en.yml |
The Recomp view adds a localized GX worker switch, loads its state from RECOMP_GX_WORKER, and saves changes unless settings are loading. The helper text describes the graphics-thread option and says changes take effect on the next game start. The prevent-stutters row changes to the middle style. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature
Suggested reviewers: dirkdoes
Merge Risk: 
Minimal · up to 68fe6
-
The GX worker option is correctly wired with no identified merge-blocking issue.
Pre-merge checks: 
3 · 
2
-
Failed checks: 2 warnings Passed checks: 3 passedFull details: Description check
-
Explanation
The description explains the setting, configuration output, and restart behavior, but it omits the required Purpose, How to Test, What Has Been Changed, Related Issue Link, and checklist sections from the repository template.
Resolution
Update the description to include all template sections. Add testing steps, a detailed change summary, the related issue link or an explicit indication that none exists, and the relevant checklist status.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit flips the GX switch with care,
A graphics thread joins the game’s affair.
The setting waits for launch anew,
Its checked state loads, then saves on cue.
I twitch my nose and hop away.
Comment @coderabbitai help to get the list of available commands.
Adds a WiiCompiled setting to turn the separate graphics (GX worker) thread on or off. It writes
[video] gx_workerin Config.toml and takes effect the next time the game starts.Summary by CodeRabbit