Skip to content

Add option to turn off the GX worker thread - #548

Merged
patchzyy merged 1 commit into
mainfrom
recomp-gx-worker-option
Oct 25, 2026
Merged

patchzyy merged 1 commit into
mainfrom
recomp-gx-worker-option

Conversation

@patchzyy

@patchzyy patchzyy commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Adds a WiiCompiled setting to turn the separate graphics (GX worker) thread on or off. It writes [video] gx_worker in Config.toml and takes effect the next time the game starts.

Summary by CodeRabbit

  • New Features
    • Added a setting to enable or disable GX worker rendering. It is enabled by default, and changes take effect the next time the game starts.
    • Added guidance to disable the setting if crashes or graphics issues occur.
  • Style
    • Updated the placement of the prevent-stutters setting in the Recomp settings.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: e146d6ac-dfe1-487c-8076-8f9737c1ca5b
Commits

Reviewing files that changed from the base of the PR and between f3d8ddd and 68fe6c0.

Files selected for processing: 5
  • WheelWizard/Features/Settings/ISettingsServices.cs
  • WheelWizard/Features/Settings/SettingsManager.cs
  • WheelWizard/Features/Settings/Views/RecompSettings.axaml
  • WheelWizard/Features/Settings/Views/RecompSettings.axaml.cs
  • WheelWizard/Resources/Languages/en.yml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The Recomp settings view adds a GX worker switch. Its state loads from and saves to a new setting, which defaults to true. Localized text describes the graphics-thread option and when changes take effect.

Changes: GX worker setting

Layer / File(s) Summary
Register the GX worker setting
WheelWizard/Features/Settings/ISettingsServices.cs, WheelWizard/Features/Settings/SettingsManager.cs
The settings interface and manager expose RECOMP_GX_WORKER. The manager registers video.gx_worker with a default value of true.
Connect the GX worker switch
WheelWizard/Features/Settings/Views/RecompSettings.axaml, WheelWizard/Features/Settings/Views/RecompSettings.axaml.cs, WheelWizard/Resources/Languages/en.yml
The Recomp view adds a localized GX worker switch, loads its state from RECOMP_GX_WORKER, and saves changes unless settings are loading. The helper text describes the graphics-thread option and says changes take effect on the next game start. The prevent-stutters row changes to the middle style.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: dirkdoes

Merge Risk: Minimal · up to 68fe6

The GX worker option is correctly wired with no identified merge-blocking issue.

Pre-merge checks: Passed 3 · Failed 2

Failed Failed checks: 2 warnings

Check name Status Explanation Resolution
Description check Warning The description explains the setting, configuration output, and restart behavior, but it omits the required Purpose, How to Test, What Has Been Changed, Related Issue Link, and checklist sections from… Update the description to include all template sections. Add testing steps, a detailed change summary, the related issue link or an explicit indication that none exists, and the relevant checklist status.
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files. (2 skipped: 2 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: adding an option to disable the GX worker thread.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the setting, configuration output, and restart behavior, but it omits the required Purpose, How to Test, What Has Been Changed, Related Issue Link, and checklist sections from the repository template.

Resolution

Update the description to include all template sections. Add testing steps, a detailed change summary, the related issue link or an explicit indication that none exists, and the relevant checklist status.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit flips the GX switch with care,
A graphics thread joins the game’s affair.
The setting waits for launch anew,
Its checked state loads, then saves on cue.
I twitch my nose and hop away.

Comment @coderabbitai help to get the list of available commands.

@patchzyy
patchzyy merged commit a72bde0 into main Oct 25, 2026
3 checks passed
@patchzyy
patchzyy deleted the recomp-gx-worker-option branch October 25, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant