Skip to content

🧹 [code health improvement] Resolve unnecessary clone in database module #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tcode-Motion merged 1 commit into from
Sep 15, 2026
+3 −1
Merged

🧹 [code health improvement] Resolve unnecessary clone in database module #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion stdlib/src/database.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ fn std_database_query(
None,
)
})? {
let mut row_map = IndexMap::new();
let mut row_map = IndexMap::with_capacity(column_names.len());
for (idx, name) in column_names.iter().enumerate() {
let value = match row.get_ref(idx).map_err(|e| {
RuntimeError::new(
Expand All @@ -151,6 +151,8 @@ fn std_database_query(
RuntimeValue::Str(s)
}
};
// The clone here is strictly necessary because `IndexMap` requires an owned `String`
// key, and each row constructs a fresh map containing these keys.
row_map.insert(name.clone(), value);
}
result_rows.push(RuntimeValue::Map {
Expand Down
Loading