⚡ Bolt: Optimize IR block predecessor mapping from O(N^2) to O(N) - #161
Conversation
This replaces the inner loop `.contains()` check with an O(N) adjacency list constructed via a `HashMap`, drastically improving compilation times for modules with large numbers of basic blocks. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced the$O(N^2)$ $O(N + E)$ approach using a
containscheck when building block predecessors incompiler/ir/src/builder.rswith anHashMap.🎯 Why: Reconstructing backwards CFG edges by looping over all blocks and scanning their successor vectors creates quadratic scaling. For flat, linear modules or large match statements containing tens of thousands of basic blocks, this can cause significant compilation lag.
📊 Measured Improvement:
🔬 Measurement: Added a temporary
bench_map_predecessorstest generating thousands of basic blocks, measuringbuilder.seal_function()completion time withstd::time::Instant.PR created automatically by Jules for task 8316661530692621468 started by @Tcode-Motion