⚡ Bolt: [performance improvement] optimize string allocations in formatter - #157
Conversation
Refactors `DocumentFormatter` to use a pre-allocated mutable string buffer, passing `&mut String` through recursive formatting methods instead of generating and concatenating intermediate `String` objects with `format!()`. This dramatically reduces memory allocations during formatting. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Refactored the
DocumentFormatterintools/formatter/src/lib.rsto eliminate intermediateStringallocations. Replacedformat!()macros and string concatenation with direct buffer writes (buf.push_str,write!) to a single, shared&mut Stringbuffer, pre-allocated usingString::with_capacity.🎯 Why:
The original implementation recursively allocated and concatenated new strings for every AST node (statements, expressions, etc.), which creates immense memory overhead and slows down the CPU due to constant reallocation and copying when formatting large TechScript documents.
📊 Measured Improvement:
Based on isolated benchmark testing inside the repository:
Measurements were verified locally using a dedicated Rust benchmarking suite (
perf_test.rs).PR created automatically by Jules for task 6914985605802378107 started by @Tcode-Motion