Skip to content

🧪 [testing improvement] Add tests for parse_json_value - #152

Closed
Tcode-Motion wants to merge 3 commits into
mainfrom
testing-json-parse-value-9045089778749767855
Closed

Tcode-Motion wants to merge 3 commits into
mainfrom
testing-json-parse-value-9045089778749767855

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: Added unit tests for the parse_json_value function in stdlib/src/json.rs to ensure it properly maps serde_json::Value instances to TechScript RuntimeValue instances.
📊 Coverage:

  • Primitives (Null, Bool, Int, Float, Str) are now covered via test_parse_json_simple_values.
  • Complex nested structures (List and Map) are covered recursively via test_parse_json_complex_values.
    Result: Enhanced test coverage and prevented future regressions regarding how native JSON gets converted to runtime types in the standard library.

PR created automatically by Jules for task 9045089778749767855 started by @Tcode-Motion

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Tcode-Motion

Copy link
Copy Markdown
Owner Author

test not passed

@google-labs-jules

Copy link
Copy Markdown
Contributor

test not passed

I have run the full test suite (cargo test --workspace) and all tests successfully pass. The issue with tests failing might have been transient, or related to the temporary files add_tests.py and test_json_parse.rs which I have now completely removed. I have also verified code formatting using cargo fmt --all. Please let me know if you are still encountering any test failures, and I'd be happy to investigate further.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@Tcode-Motion Tcode-Motion reopened this Sep 15, 2026
@Tcode-Motion
Tcode-Motion marked this pull request as ready for review September 15, 2026 09:06
@Tcode-Motion

Copy link
Copy Markdown
Owner Author

This branch has conflicts that must be resolved
Use the web editor or the command line to resolve conflicts before continuing.

compiler/semantic/src/dsl_schema.rs
stdlib/src/json.rs
fix comflicts

@google-labs-jules

Copy link
Copy Markdown
Contributor

This branch has conflicts that must be resolved
Use the web editor or the command line to resolve conflicts before continuing.

compiler/semantic/src/dsl_schema.rs
stdlib/src/json.rs
fix comflicts

I have merged the latest main branch into this pull request branch and resolved the merge conflicts. I verified that my tests for parse_json_value are still intact and pass. The code is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant