🧹 [Code Health] Refactor register_web_schemas into logical helpers - #150
Tcode-Motion wants to merge 3 commits into
Conversation
Splits the monolithic `register_web_schemas` function into three logically grouped helper functions: `register_web_layout_schemas`, `register_web_component_schemas`, and `register_web_form_schemas`. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
test not passes |
I have run |
Splits the monolithic `register_web_schemas` function into three logically grouped helper functions: `register_web_layout_schemas`, `register_web_component_schemas`, and `register_web_form_schemas`. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
This branch has conflicts that must be resolved compiler/semantic/src/dsl_schema.rs |
🎯 What: Refactored the monolithic 264-line
register_web_schemasfunction incompiler/semantic/src/dsl_schema.rsby breaking it down into three smaller, logically grouped helper functions:register_web_layout_schemas,register_web_component_schemas, andregister_web_form_schemas.💡 Why: The original function exceeded recommended length limits and was difficult to read and maintain due to the sheer number of
HashMapinsertions. Grouping them by domain (layout, component, form) significantly improves readability and makes future modifications easier.✅ Verification: Verified by ensuring the exact same schemas and properties are inserted into the registry, running
cargo fmt --all,cargo clippy --workspace --all-targets, and confirming all workspace tests pass withcargo test --workspace.✨ Result: Improved maintainability by reducing function length well below the limit and providing better code organization without any change in semantic behavior.
PR created automatically by Jules for task 16243899398171829417 started by @Tcode-Motion