Fix review issues #59-#74: exports, build robustness, link check, a11y, docs - #76
Merged
Merged
Conversation
…y, docs - feed.xml: feed-level <author> (RFC 4287) (#59) - llms.mjs reads links with the shared LINK_RE, so balanced-paren hrefs cannot crash the build after the page gate (#60) - renderInline strips NUL before using it as a slot marker; validate rejects C0 control characters (#61) - catalog.csv neutralises formula-leading cells (#62) - shortlist button's accessible name starts with its visible text (#63) - one entry walker (lib/entry-files.mjs) for build, validate, sync-counts and check-links; kebab-case ids enforced (#64) - check-links: pure parts in lib/link-check.mjs with tests, multi-part suffixes, inert report URLs; V16 rejects private hosts (#65) - client lookups without a prototype; shortlist export slash fix (#66) - tests for all of the above (#67, partly) - "not legal advice" in README, licences guide, footers, CREDITS (#68) - ROADMAP without drifting counts or shipped items (#69) - contributor path aligned; TEMPLATE starts needs-review (#70) - README positioning vs magictools / awesome-gamedev, with credit (#71) - specs to docs/design, research-index out of user guides, trust-score labelled as a rubric (#73) - homepage WebSite + Dataset JSON-LD (#74) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the code and doc findings from the 2026-10-04 repo review. No entry's licence data changes.
Closes #59, closes #60, closes #61, closes #62, closes #63, closes #64, closes #65, closes #66, closes #68, closes #69, closes #70, closes #71, closes #73, closes #74.
Code
feed.xmlhas a feed-level<author>, as RFC 4287 requires.llms.mjsnow reads links with the sharedLINK_REfrommarkdown.mjs, so a balanced-paren href can't crash the build after the page gate.renderInlinestrips NUL before using it as the slot marker. The validator rejects C0 control characters (with file:line).catalog.csvputs an apostrophe before cells that start with= + - @, tab or CR.Add to shortlist: <name>/On shortlist: <name>, so it matches the visible text (WCAG 2.5.3).site/lib/entry-files.mjsis the one entry walker for build, validate, sync-counts and check-links. Hidden and_scratchfolders are skipped everywhere. Kebab-case ids are enforced.site/lib/link-check.mjs, with tests.co.uk,github.ioand similar suffixes are compared correctly..localand IP-literal URLs.new-entrycreates a missing category folder and points at the quick check.Docs
docs/licenses.md, every page footer and the CREDITS export.npm run counts.needs-review.npm test && npm run validateis named as the quick local check (PR template too).docs/superpowers/specs/todocs/design/and are listed in the layout.Left open on purpose
data.js.Verification (local)
checks.test: 124 assertions pass (5 new for V16).lib.test: 350 assertions pass (about 40 new).validate: 392 entries, no broken links.build: 392 entry pages. The new<author>, JSON-LD and aria-labels show up insite/dist.🤖 Generated with Claude Code