Repository navigation
fix(ci): run every documented example falsifier in smoke - #443
Merged
Merged
Conversation
Example READMEs documented falsifiers that no job ran. Only one flag per row was in the catalog, and the weekly sweep reads only showcase/. Any of those checks could stop failing unnoticed. Add the 19 remaining non-render falsifiers to their catalog rows: - cross-version-property-delete --unset-instead (7) - gn-zone-iterate --no-offset (4), --unpair-foreach (5), --foreach-main (5) - gn-sim-fountain --euler (4), --prebake-trap (5), --calc-to-frame (6) - gn-bundle-roundtrip --mismatch (3), --bypass (4), --mismatch-mark (5) - exit-pre-sidecar --no-handler, --silent-handler, --wrong-text, --write-in-main (sidecar must fail) - ngon-triangulate --skip-triangulate (4), unapplied-scale-gltf --bake (4), coincident-vert-weld --weld (4) - usd-export-evaluation-mode --evaluation-mode VIEWPORT (4) - gn-modifier-inputs --api dict (5, from 5.2; exits 0 on 5.1) They run on every smoke leg, so they run at least weekly. The READMEs' "Smoke does not pass" sentences now list them as catalog falsifiers, which check_smoke_catalog enforces. The ROADMAP item that deferred this is removed. Render-path diagnostics (--falsify, --close-camera, --probe) and mode switches (--force-run, --obj) stay out of smoke. Closes #362 Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
CI evidence before merge: all checks pass ( 13 pass ). Blender Smoke on PR head: Blender 5.2.2 LTS / Blender 4.5.14 LTS. Summaries (happy path; falsifiers) per leg: 143 passed, 1 skipped, 0 failed;162 passed, 0 skipped, 0 failed;141 passed, 3 skipped, 0 failed;147 passed, 15 skipped, 0 failed; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #362.
What changed
Catalog:
tests/smoke/catalog.jsongains 19 falsifiers on 10 existing rows. These are every non-render falsifier the example READMEs documented but no job ran. The rows'falsifierslists already supported several entries, so no new key or cron job is needed. They run on every smoke leg, which also satisfies "at least weekly".--unset-instead(7)--no-offset(4),--unpair-foreach(5),--foreach-main(5)--euler(4),--prebake-trap(5),--calc-to-frame(6)--mismatch(3),--bypass(4),--mismatch-mark(5)--no-handler,--silent-handler,--wrong-text,--write-in-main(sidecar must fail)--skip-triangulate/--bake/--weld(4)--evaluation-mode VIEWPORT(4)--api dict(5;min_version5.2)READMEs: the 10 "Smoke does not pass …" sentences now name these as catalog falsifiers.
check_smoke_catalogrejected every stale one until it was fixed. Gallery pages are regenerated.ROADMAP: removed the item that deferred this decision.
Left out of smoke on purpose:
--falsify(writes a PNG),--close-camera,--probe;--force-run,--obj,--api rna.Evidence
Live run:
tests/smoke/run_catalog.pyover a 10-row subset catalog, on local binaries:--api dict, from 5.2)--api dict,--subscript-registered)--api dicton 5.1.2: run directly, it exits 0 (api=dict blender=(5, 1, 2),gn-modifier-inputs OK). That is why it hasmin_version5.2, and the README says so.check_smoke_catalog.pyandcheck_exit_code_readme.pypass.🤖 Generated with Claude Code