Skip to content

fix(showcase): hull only the points so showcase colliders come out closed - #437

Merged
TMHSDigital merged 1 commit into
mainfrom
fix/showcase-hull-colliders
Oct 5, 2026
Merged

TMHSDigital merged 1 commit into
mainfrom
fix/showcase-hull-colliders

Conversation

@TMHSDigital

Copy link
Copy Markdown
Owner

Closes #386 (part 2; part 1 was the snippet and template in #407).

What changed

  • All 58 showcase copies of convex_hull_collider remove the source edges before bmesh.ops.convex_hull, then delete any vertex left without a face. Before this, the source edges survived the hull, so colliders carried wire edges and interior vertices and over-counted triangles.
  • 58 README "Collider tris" rows and the budget rows in crate-stack and stone-archway carry the measured counts. Export rows now state bytes per version (A / B / C bytes (4.5.11 / 5.1.2 / 5.2.1)).
  • Updated showcase/gallery.json witness callouts and regenerated docs/gallery/.

Evidence

Live run: all 58 pieces on local 4.5.11, 5.1.2 and 5.2.1 (.scratch/ binaries).

  • 174/174 runs exit 0.
  • Collider triangle counts are identical across all three versions for every piece.
  • 46/58 counts changed, e.g. archery-target 1083 → 634 and anvil 134 → 130.

Local checks, all passing:

  • check_witnesses.py: every quoted count matches its README.
  • check_helper_drift.py --strict
  • check_site_links.py: 0 failures.
  • check_counts.py

Inspection only: historical remodel notes (chopping-block, grindstone, hitching-post, signpost, wheelbarrow) still quote earlier counts on purpose; they describe past states.

🤖 Generated with Claude Code

…osed

The 58 showcase copies of convex_hull_collider ran bmesh.ops.convex_hull
over a copy of the full source mesh. The source edges survived the hull
and left wire edges and interior vertices in the collider, so the
"closed" collider was not closed and its triangle count was inflated.

Remove the source edges before the hull and delete any vertex the hull
left without a face, matching the snippet and template fix in #407.

Measured on 4.5.11, 5.1.2 and 5.2.1: 174/174 runs exit 0 and collider
triangle counts are identical across versions. 46 of 58 counts changed
(e.g. archery-target 1083 -> 634, anvil 134 -> 130). README collider and
export rows and the gallery witness callouts carry the new numbers.

Closes #386

Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added showcase Budget-conformance props under showcase/ documentation Improvements or additions to documentation labels Oct 5, 2026
@TMHSDigital

Copy link
Copy Markdown
Owner Author

CI evidence before merge: all checks pass ( 13 pass ). Blender Smoke on PR head: Blender 5.2.2 LTS / Blender 4.5.14 LTS. Summaries (happy path; falsifiers) per leg: 143 passed, 1 skipped, 0 failed;143 passed, 0 skipped, 0 failed;141 passed, 3 skipped, 0 failed;136 passed, 7 skipped, 0 failed;

@TMHSDigital
TMHSDigital merged commit fd832c5 into main Oct 5, 2026
13 checks passed
@TMHSDigital
TMHSDigital deleted the fix/showcase-hull-colliders branch October 5, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation showcase Budget-conformance props under showcase/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

snippets: convex_hull_collider keeps the source faces, producing non-manifold colliders with duplicate faces

1 participant