Repository navigation
fix(showcase): hull only the points so showcase colliders come out closed - #437
Merged
Merged
Conversation
…osed The 58 showcase copies of convex_hull_collider ran bmesh.ops.convex_hull over a copy of the full source mesh. The source edges survived the hull and left wire edges and interior vertices in the collider, so the "closed" collider was not closed and its triangle count was inflated. Remove the source edges before the hull and delete any vertex the hull left without a face, matching the snippet and template fix in #407. Measured on 4.5.11, 5.1.2 and 5.2.1: 174/174 runs exit 0 and collider triangle counts are identical across versions. 46 of 58 counts changed (e.g. archery-target 1083 -> 634, anvil 134 -> 130). README collider and export rows and the gallery witness callouts carry the new numbers. Closes #386 Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
CI evidence before merge: all checks pass ( 13 pass ). Blender Smoke on PR head: Blender 5.2.2 LTS / Blender 4.5.14 LTS. Summaries (happy path; falsifiers) per leg: 143 passed, 1 skipped, 0 failed;143 passed, 0 skipped, 0 failed;141 passed, 3 skipped, 0 failed;136 passed, 7 skipped, 0 failed; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #386 (part 2; part 1 was the snippet and template in #407).
What changed
convex_hull_colliderremove the source edges beforebmesh.ops.convex_hull, then delete any vertex left without a face. Before this, the source edges survived the hull, so colliders carried wire edges and interior vertices and over-counted triangles.A / B / C bytes (4.5.11 / 5.1.2 / 5.2.1)).showcase/gallery.jsonwitness callouts and regenerateddocs/gallery/.Evidence
Live run: all 58 pieces on local 4.5.11, 5.1.2 and 5.2.1 (
.scratch/binaries).Local checks, all passing:
check_witnesses.py: every quoted count matches its README.check_helper_drift.py --strictcheck_site_links.py: 0 failures.check_counts.pyInspection only: historical remodel notes (chopping-block, grindstone, hitching-post, signpost, wheelbarrow) still quote earlier counts on purpose; they describe past states.
🤖 Generated with Claude Code