Repository navigation
fix(ci): one requirements file and one command for every local check - #432
Merged
Merged
Conversation
A contributor could not reproduce Validate without reading the YAML: test deps were pinned inline (`pip install PyYAML==6.0.2`, `numpy==2.2.6 Pillow==11.2.1`), invisible to Dependabot, and three checks existed only as heredoc Python inside validate.yml. Pillow 11.2.1 also predates the 11.3.0 fix for CVE-2025-48379. - requirements-dev.txt pins PyYAML, numpy and Pillow 11.3.0 (plus the site build's Jinja2); Validate installs from it and Dependabot watches it. - tests/run_all.py runs every tests/check_*.py and test_*.py, the smoke harness tests, the generator --check modes, the landing build the link check needs, the gallery-drift check, and the inline validate.yml heredoc checks, extracted from the workflow at run time so there is still one copy of each. CONTRIBUTING documents it. - .gitattributes keeps *.sh LF so Windows checkouts run under WSL bash. Closes #364 Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Owner
Author
|
CI evidence before merge: all checks pass ( 13 pass ). Blender Smoke on PR head: Blender 5.2.2 LTS / Blender 4.5.14 LTS. Summaries (happy path; falsifiers) per leg: 143 passed, 1 skipped, 0 failed;143 passed, 0 skipped, 0 failed;141 passed, 3 skipped, 0 failed;136 passed, 7 skipped, 0 failed; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #364.
Change
requirements-dev.txt:-r scripts/site/requirements.txt(Jinja2), plusPyYAML==6.0.2,numpy==2.2.6andPillow==11.3.0(was 11.2.1; 11.3.0 fixes CVE-2025-48379);pip installlines invalidate.ymlnow install from it;/.tests/run_all.py:tests/check_*.pyandtests/test_*.py,tests/smoke/test_harness.py,build_claude_rules --checkandbuild_plugin_dist --check;check_site_linksneeds, and the committed-gallery-vs-generator check;validate.ymlheredoc checks, extracted from the workflow at run time. This avoids a second copy that could drift, which is why I didn't move them into separate files;-kfilters by name..gitattributes:*.sh text eol=lf.Evidence (fresh venv, Python 3.13, Windows)
pip install -r requirements-dev.txtinstalls Pillow 11.3.0, numpy 2.2.6 and PyYAML 6.0.2.tests/test_measure_hero_drift.pypasses on Pillow 11.3.0.python tests/run_all.py: 28 passed, 0 failed. That includes the three extracted heredoc checks (plugin manifest, Claude packaging, content counts).examples/gallery.jsonwithout regenerating makesrun_all -k "gallery matches"FAIL and name the two stale pages. Restored, it passes.validate.ymlanddependabot.ymlparse.🤖 Generated with Claude Code