Skip to content

fix(build): backport Boost.Locale support for CMake 4.5 - #6166

Open
ReenigneArcher wants to merge 1 commit into
masterfrom
codex/fix-boost-locale-cmake-45
Open

ReenigneArcher wants to merge 1 commit into
masterfrom
codex/fix-boost-locale-cmake-45

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Both openSUSE Tumbleweed COPR builds stopped at CMake configuration. CMake 4.5 rejected the Boost.Locale umbrella header include/boost/locale.hpp in a source group rooted at include/boost/locale. x86_64 build log, aarch64 build log

The CPM lockfile applies the upstream Boost.Locale fix when Sunshine fetches Boost 1.92.0 on non-Windows builds with CMake 4.5 or newer. The patch removes the umbrella header from the directory-based group and keeps its existing standalone group. Upstream fix

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • Reproduced the source_group failure with the locked Boost archive and CMake 4.5.0.
  • Configured Sunshine through the CPM fallback and built boost_locale on x86_64 Ubuntu WSL with CUDA disabled.
  • Checked patch selection with CMake 4.5.0, CMake 3.28.3, and the Windows condition. CMake lint and git diff --check passed.
  • Hosted COPR validation for both Tumbleweed architectures is pending.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

This pull request was generated by Codex (GPT-6.2 Sol, extra high thinking level).

Copy link
Copy Markdown
Member Author

This pull request was generated by Codex (GPT-6.2 Sol, extra high thinking level).

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant