Skip to content

build(deps): migrate submodules to CPM - #6158

Merged
ReenigneArcher merged 3 commits into
masterfrom
codex/cpm-submodule-migration
Nov 22, 2026
Merged

ReenigneArcher merged 3 commits into
masterfrom
codex/cpm-submodule-migration

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Description

Move 13 direct Git submodules to pinned CPM packages so native builds fetch the sources they need during CMake configuration. CMake preserves dependency-qualified includes for Simple-Web-Server and Moonlight across native and Flatpak checkout layouts.

Flatpak Builder stages nine pinned Git sources before CMake runs, and the Flathub release archive carries each source file. Vulkan Headers come from the prepared FFmpeg bundle when available. Older bundles retain the build-deps fallback.

The Flatpak metadata uses upstream project names and mirror URLs for Renovate lookups. The commit-only pin support is in the shared preset change. LizardByte/.github #1018

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • The initial Windows MSYS2 UCRT64 Release build and Web UI passed, including 19 focused GoogleTest cases and the CPM-sourced libvirtualhid icon.
  • After the include changes, Windows CMake configuration passed and the HTTP, input, ViGEmClient, pairing test, and RTSP test sources compiled.
  • Ubuntu WSL configured with Flatpak sources staged and downloads disabled. The Vulkan encoder, HTTP, and input sources compiled against the staged dependencies, and the build used the filtered FFmpeg header tree. Both pinned Linux FFmpeg archives contain Vulkan Headers. The WSL check used x86_64 with CUDA and the tray disabled.
  • Verified the generated Flathub archive contains all nine staged source files. The shared preset detected all nine dependencies and replaced the four commit-only pins in local testing.
  • Ran the locked Python sync, clang-format, and git diff --check.

Local verification did not cover a full Flatpak build, Windows WiX packaging, macOS, or FreeBSD.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

This pull request was generated by Codex using GPT-6.2 Sol at extra-high thinking level.

@ReenigneArcher

Copy link
Copy Markdown
Member Author

This pull request was generated by Codex using GPT-6.2 Sol at extra-high thinking level.

@codecov

codecov Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher ReenigneArcher added the roadmap This PR closes a roadmap entry label Nov 22, 2026
@codecov

codecov Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.29%. Comparing base (575456e) to head (a595d43).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6158   +/-   ##
=======================================
  Coverage   51.29%   51.29%           
=======================================
  Files         148      148           
  Lines       32591    32591           
  Branches    13750    13750           
=======================================
+ Hits        16718    16719    +1     
+ Misses      14557    14520   -37     
- Partials     1316     1352   +36     
Flag Coverage Δ
Alpine-aarch64 34.73% <ø> (ø)
Alpine-x86_64 34.85% <ø> (ø)
Archlinux 35.57% <ø> (ø)
FreeBSD-amd64 35.61% <ø> (ø)
Homebrew-macos-15 49.11% <ø> (ø)
Homebrew-macos-26 49.48% <ø> (ø)
Homebrew-ubuntu-24.04 38.09% <ø> (+<0.01%) ⬆️
Linux-AppImage-aarch64 40.80% <ø> (+<0.01%) ⬆️
Linux-AppImage-x86_64 41.04% <ø> (ø)
PowerShell 100.00% <ø> (ø)
Web-UI 57.76% <ø> (ø)
Windows-AMD64 41.52% <ø> (ø)
Windows-ARM64 35.44% <ø> (ø)
macOS-arm64 41.86% <ø> (-0.02%) ⬇️
macOS-x86_64 40.76% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 19 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575456e...a595d43. Read the comment docs.

@github-actions

Copy link
Copy Markdown
Last Updated 2026-11-22 01:22:55 UTC
Source Run CI Run #6915
Commit a595d431e96974dc64ebec81db932fd6b2a9f93f

Screenshot Comparison

PR #6158 screenshots vs screenshots baseline.

Matrix: AppImage-aarch64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: AppImage-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

@ReenigneArcher
ReenigneArcher merged commit cd42504 into master Nov 22, 2026
81 of 83 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/cpm-submodule-migration branch November 22, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

roadmap This PR closes a roadmap entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

c/c++ package manager

1 participant