Skip to content

build(linux): install CUDA from NVIDIA component archives - #6157

Merged
ReenigneArcher merged 5 commits into
masterfrom
build/appimage-cuda-redistributables
Nov 22, 2026
Merged

ReenigneArcher merged 5 commits into
masterfrom
build/appimage-cuda-redistributables

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Description

Follow up to #6155: install only the CUDA toolkit components Sunshine needs instead of downloading the full runfile.

  • Use seven checksum-pinned CUDA 13.5.0 archives for AppImage, Docker/DEB, and other builds using scripts/linux_build.sh that need the bundled toolkit. The download is 102.4 MB on x86-64 and 91.6 MB on ARM64. Ubuntu 26.04 and 26.10 still select the pinned toolkit by default; explicit distro packages and --cuda-runfile remain available.
  • Prefetch the same seven archives per architecture in Flatpak, keeping the toolchain at /app/cuda. Remove the runfile-only libxml2 dependency. Keep the CI cache boundary unchanged.
  • Install legacy Copr's existing CUDA 12.9.1 from three checksum-pinned archives per architecture (83.6 MB x86-64; 75.9 MB ARM64), preserving the existing glibc patch and GPU targets. Modern Copr already uses CUDA 13.5 archives.

Arch keeps its distro toolkit. The CLion development image keeps its full CUDA SDK for general development tools.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • Bash syntax, ShellCheck, manifest checks, and diff checks passed. Tested default, existing-compiler, and explicit-override selection across the affected build-script routes.
  • Verified NVIDIA archive checksums and exercised extraction for both architectures, including Flatpak's offline install commands and the legacy Copr install recipe. Legacy glibc patches applied to both layouts.
  • A cold CUDA 13.5 x86-64 archive install took 21 seconds locally. CMake 4.3/Ninja with GCC 14.2 configured, compiled and linked a mixed CUDA/C++ probe targeting all 11 CUDA 13 Sunshine GPU targets; the host executable ran. An x86-64 CUDA 12.9 compile/link smoke test also passed with the existing header patch.
  • No GPU runtime use or full package build locally. CI still needs to verify packaging, native ARM64 compilation, and runner timings.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

Prepared with OpenAI Codex; exact model and reasoning level were unavailable.

@ReenigneArcher ReenigneArcher changed the title build(linux): use CUDA component archives for AppImage build(linux): install CUDA from NVIDIA component archives Nov 21, 2026
@codecov

codecov Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 1.48kB (0.15%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sunshine-esm 1.01MB 1.48kB (0.15%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sunshine-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
images/logo-*.svg -661 bytes 1.48kB -30.92%
images/logo-*.svg (New) 2.14kB 2.14kB 100.0% 🚀

@codecov

codecov Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.29%. Comparing base (575456e) to head (7d45147).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #6157    +/-   ##
========================================
  Coverage   51.29%   51.29%            
========================================
  Files         148      148            
  Lines       32591    32591            
  Branches    13750    13752     +2     
========================================
+ Hits        16718    16719     +1     
+ Misses      14557    13598   -959     
- Partials     1316     2274   +958     
Flag Coverage Δ
Alpine-aarch64 34.73% <ø> (ø)
Alpine-x86_64 34.85% <ø> (ø)
Archlinux 35.57% <ø> (ø)
FreeBSD-amd64 35.61% <ø> (-0.01%) ⬇️
Homebrew-macos-15 49.11% <ø> (ø)
Homebrew-macos-26 49.47% <ø> (-0.02%) ⬇️
Homebrew-ubuntu-24.04 38.09% <ø> (+<0.01%) ⬆️
Linux-AppImage-aarch64 40.79% <ø> (-0.01%) ⬇️
Linux-AppImage-x86_64 40.93% <ø> (-0.12%) ⬇️
PowerShell 100.00% <ø> (ø)
Web-UI 57.76% <ø> (ø)
Windows-AMD64 41.52% <ø> (ø)
Windows-ARM64 35.43% <ø> (-0.01%) ⬇️
macOS-arm64 41.87% <ø> (ø)
macOS-x86_64 40.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 36 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575456e...7d45147. Read the comment docs.

@github-actions

github-actions Bot commented Nov 22, 2026 •

Copy link
Copy Markdown
Last Updated 2026-11-22 01:42:31 UTC
Source Run CI Run #6916
Commit 7d45147f92b613088adfdd1184c0351cdff8b1cc

Screenshot Comparison

PR #6157 screenshots vs screenshots baseline.

Matrix: AppImage-aarch64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: AppImage-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

@ReenigneArcher
ReenigneArcher marked this pull request as ready for review November 22, 2026 01:03
@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit b45431e into master Nov 22, 2026
81 of 83 checks passed
@ReenigneArcher
ReenigneArcher deleted the build/appimage-cuda-redistributables branch November 22, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant