Repository navigation
feat(zed): the extension installs from zed's registry and downloads its series' payload where no server is named - #94
Sunrisepeak wants to merge 4 commits into
Conversation
…ts series' payload where no server is named Zed's registry (zed-industries/extensions) asks an extension that provides a language server only for an id ending in -language-server, a license in the extension's own directory, and a server that is downloaded or found rather than bundled. The extension is now mcppls-language-server with editors/zed/LICENSE, and starts the server named by lsp.mcppls.binary, else an mcppls on PATH, else the payload of its series (mcppls-payload-X.Y.0.tar.gz of vX.Y.0), downloaded once into its work directory. It no longer starts the payload under the user data directory, which an install from the registry does not have and which the extension cannot check. devtools links the extension under the new id and removes an install under the former one. zed 0.23.1. Closes #93.
… its arguments alone, so they include serve Measured in Zed 1.29.3: a command named there without arguments was started with none.
…e checks follow the new id The review of #94 found: - release-checks.yml still looked for installed/mcppls, which every release candidate would have failed, and checked its removal vacuously; - the extension always downloaded vX.Y.0, so a server patch (server-vX.Y.Z, which carries the payload) never reached Zed. It now names its server, SERVER in resolve.rs, as the VS Code and CLion packages carry theirs, and a server patch reaches Zed with the extension's next patch; - a download cut short could leave a runner that exists but is not whole: a marker written after the check now says the payload is complete; - the former-id cleanup decided by the id, which Zed's directory name always matches: it now removes only a link or an install whose repository is this one; - zed-unit built with the runner's Rust: it now uses ZED_RUST_VERSION, the registry's 1.90; - docs, the release manifest and comments that still described the payload under the user data directory as Zed's.
After review
|
…'s and the VS Code Marketplace's name mcppls-language-server repeated the abbreviation of the suffix the registry asks for; the repository and the VS Code Marketplace already name the product mcpp-language-server.
The id is
|
|
Closed: the Zed extension stays in this repository (editors/zed, installed as a dev extension) and is not submitted to Zed's extension registry, so the registry's id, license and server-download requirements this pull request met are not needed. The branch is kept. |
Summary
Closes #93. The Zed extension meets the requirements of Zed's extension registry (zed-industries/extensions), so that it can be submitted there; the submission itself is a pull request a person opens in that repository (its AI policy admits no autonomous agent), and docs/92-release.md now says how.
mcppls-language-server: the registry asks an extension that provides only a language server for a-language-serveror-lspsuffix, and an id never changes once published. The server's name in Zed's settings staysmcppls.editors/zed/LICENSE, the repository's Apache-2.0: the registry reads the extension's own directory, not the repository's root.resolve.rs,lib.rs):lsp.mcppls.binaryin Zed's settings (Zed's own way to name a server), elsemcpplson PATH, else the payload of the extension's series,mcppls-payload-X.Y.0.tar.gzof the releasevX.Y.0(the one release of a series with every asset), downloaded once into the work directory Zed gives the extension, with Zed's installation status shown while it downloads and a failure naming the release and the remedy. The fallback to<user data>/mcppls/payloadis gone: an install from the registry does not have it, and the extension, which cannot look outside its work directory, could not tell whether it was there.mcppls(when it is a link or this extension), so that Zed does not run two extensions with one server.zed 0.23.1(version --bump zed); CHANGELOG## [zed 0.23.1].What ran
cargo testineditors/zed: 8 passed (the order of sources, the series' release, each platform's runner, the errors, stale payloads).cargo build --release --target wasm32-wasip2with Rust 1.90, the registry's toolchain: no warning.editors/zed/LICENSEaccepted;validateManifestandvalidateExtensionsTomlpass formcppls-language-server0.23.1; itszed-extensionCLI (the SHA its CI pins) packages the directory:provides: ["language-servers"].mcpp test -p devtools: passed, including the new case "the install under the former id goes, and an unrelated one under that id stays";devtools check allandversion --checkpass.zed), Linux x86_64, under Xvfb with lavapipe, the packaged extension unpacked underextensions/installed/mcppls-language-serveras the registry installs it, PATH/usr/bin:/bin(nomcppls), nolspsettings, on theinferredfixture: the extension downloadedmcppls-payload-0.23.0intoextensions/work/mcppls-language-server/, Zed started its runner and image, and the server started the payload's clangd 23.1.0-mcppls.12 and builtstdandhello.greet:detailforsrc/greet/greet.cppm.cargo test).