Repository navigation
ci: the MSVC fixtures build with the pinned LLVM, which the runner's MSVC STL accepts - #92
Merged
Merged
Conversation
…MSVC STL accepts compdb-clang-cl-std and compdb-clangxx-msvc-std fail on main since the windows runner image moved to MSVC 14.52, whose STL refuses a Clang older than 22 (STL1000); the fixtures' builds took clang++ and clang-cl from the image's own LLVM (C:\Program Files\LLVM), which is older. The developer environment the fixtures build in now has the pinned LLVM (LLVM_VERSION, 23.1.3, installed by the job, carrying clang++ and clang-cl) first on its PATH. The server under test keeps the host's PATH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conformance (win32-x64, build-26100)fails on main (nightly of d9185c4, and every pull request since) in twofixtures,
compdb-clang-cl-stdandcompdb-clangxx-msvc-std:The runner image moved to MSVC 14.52, and the fixtures' own builds took
clang++andclang-clfrom theimage's LLVM (
C:/Program Files/LLVM/bin), which is older than 22. The job already installs the pinned LLVM(
LLVM_VERSION, 23.1.3, whose Windows archive carriesclang++.exeandclang-cl.exe); the MSVC developerenvironment the fixtures build in now has its
binfirst onPATH. The server under test runs without thatenvironment, as before.
What ran
The fixture logs of the failing run name the image's drivers (
+ C:/Program Files/LLVM/bin/clang++.exe ...).The pinned archive's listing (
llvm-23.1.3-r4-windows-x86_64.zip) hasbin/clang-cl.exeandbin/clang++.exe.The fix is proved by this pull request's own Windows conformance job.