Repository navigation
ArteCheck: round the tolerated minimum duration to whole frames - #304
Merged
Merged
Conversation
25 frames - 15% = 21.25 frames: the message showed "21 fr" but the check compared against 850 ms, so 21 frames was reported. The accepted minimum is now frame-rounded once, so the displayed limit, the duration check, dialog splits and gap fixes agree: 21 frames accepted, 20 reported (matches Triathlon-rally's web checker). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At 25 fps with a 25-frame minimum and 15% tolerance the accepted minimum is 21.25 frames (850 ms). The message showed it as "21 fr" (
FormatDurationrounds to frames), but the check compared against 850 ms, so a 21-frame subtitle was reported. The dialog split (Ceiling→ 22-frame parts) and the gap-fix capacity used the same unrounded value.AcceptedMinimumDurationMsnow rounds the tolerance result withRoundToFrameonce, so all four places agree: 21 frames accepted, 20 reported. Same rule as Triathlon-rally's WebEditor fix (SubtitleEdit/subtitleedit#15185). The short-minimum branch is already whole frames.Tests:
DurationToleranceTests(20/21/22 frames + message). The 21-frame case fails before the fix; 93/93 pass.🤖 Generated with Claude Code