Repository navigation
ArteCheck: take an odd missing gap frame off the previous out time - #302
Merged
Merged
Conversation
A 4-frame gap (1 frame short of ARTE's 5) moved the next in time one frame later. Take that frame off the previous out time instead, like ARTE's own tooling does; larger shortfalls are still shared, with the odd frame on the out time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to SubtitleEdit/subtitleedit#15185 (comment from @Triathlon-rally).
A gap 1 frame short of the minimum (e.g. 4 → 5 frames) was fixed by moving the next in time one frame later (
missing / 2= 0 for the previous out time). ARTE's web implementation takes that frame off the previous out time instead, so the two tools wrote different time codes.(missing + 1) / 2). A 4-frame gap now keeps the next in time unchanged.MinimumGap_SharedBetweenOutAndInTimeupdated (5 missing → 3 out / 2 in), new testMinimumGap_OneMissingFrameComesOffThePreviousOutTime.Tests: 89 passed.
No version bump / release in this PR.
🤖 Generated with Claude Code