Repository navigation
feat(app): keep NEW badges across patch releases - #136
Merged
Merged
Conversation
A bugfix release used to count as an update and move the badge baseline to the version being left behind, so shipping 1.5.1 cleared everything 1.5.0 had badged. The baseline now moves only when the major or minor version changes: 1.5.0 -> 1.5.1 keeps 1.5.0's badges (plus anything stamped 1.5.1), and the next feature release clears them as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
WhatsNewServicetreated any version change as an update and moved the badge baseline to the version being left behind. Shipping a bugfix release (1.5.0 → 1.5.1) therefore cleared every badge 1.5.0 had shown, often before most users had seen them.Change
The baseline now only moves when the major or minor version changes. A patch-only update keeps the stored baseline.
Stamping a property
1.5.1in a bugfix release still badges it.Tests
Five new cases in
whats_new_service_test.dart, one per row above. Against the old service the two patch-release cases fail; the other three are controls that pass either way.whats_new_service_test,new_badges_widget_testandnew_badges_shipped_testall pass.Docs: the "NEW badges" section of
docs/FILTER_SCHEMA.mdand the matching note inCLAUDE.md.🤖 Generated with Claude Code