Repository navigation
Fix violations of S3776: Cognitive Complexity of methods is too high - #1750
Merged
Merged
Conversation
bart-vmware
changed the title
Contributor
Summary - All Code Coverage (ubuntu-latest)
|
bart-vmware
force-pushed
the
fix-S3776-cognitive-complexity
branch
from
September 29, 2026 07:46
0d377aa to
096b74c
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The refactors preserve existing behavior while satisfying the requested analyzer configuration.
Review effort: Balanced
Findings: None
What changed in this PR
Reduces cognitive complexity across Steeltoe while enabling S3776 warnings in Debug and Release builds.
Changes:
- Extracts focused helper methods from complex routines.
- Simplifies nested control flow without changing behavior.
- Enables S3776 as a warning in both rulesets.
| File | Description |
|---|---|
Steeltoe.Release.ruleset |
Enables S3776 warnings. |
Steeltoe.Debug.ruleset |
Promotes S3776 to warning. |
src/Management/test/GitProperties.Build.Test/PropertiesFile.cs |
Simplifies property parsing. |
src/Management/test/GitProperties.Build.Test/GitRepositoryBuilder.cs |
Simplifies directory exclusion. |
src/Management/src/Prometheus/PrometheusExtensions.cs |
Extracts pipeline configuration. |
src/Management/src/GitProperties.Build/GenerateGitPropertiesCacheTask.cs |
Extracts cache generation. |
src/Management/src/GitProperties.Build/ComposeGitPropertiesTask.cs |
Extracts dirty-state handling. |
src/Management/src/Endpoint/ManagementPort/ManagementPortStartupFilter.cs |
Extracts binding logic. |
src/Management/src/Endpoint/Actuators/Info/Contributors/GitInfoContributor.cs |
Extracts property parsing. |
src/Management/src/Endpoint/Actuators/Hypermedia/HypermediaService.cs |
Extracts link generation. |
src/Management/src/Endpoint/Actuators/DbMigrations/DbMigrationsEndpointHandler.cs |
Simplifies null handling. |
src/Discovery/src/Eureka/ValidateEurekaClientOptions.cs |
Extracts URL validation. |
src/Discovery/src/Eureka/EurekaClient.cs |
Separates request creation and sending. |
src/Discovery/src/Eureka/Configuration/EurekaInstanceOptions.cs |
Separates port updates. |
src/Connectors/src/Connectors/RabbitMQ/RabbitMQConnectionStringBuilder.cs |
Extracts query parsing. |
src/Connectors/src/Connectors/MongoDb/MongoDbConnectionStringBuilder.cs |
Extracts query parsing. |
src/Connectors/src/Connectors/ConnectionStringPostProcessor.cs |
Separates binding processing. |
src/Configuration/src/Placeholder/PropertyPlaceHolderHelper.cs |
Extracts placeholder resolution. |
src/Configuration/src/ConfigServer/ConfigServerDiscoveryService.cs |
Extracts discovery lookup. |
src/Configuration/src/ConfigServer/ConfigServerConfigurationProvider.cs |
Extracts data and response handling. |
src/Configuration/src/CloudFoundry/ServiceBindings/PostProcessors/CredHubCloudFoundryPostProcessor.cs |
Simplifies credential processing. |
src/Common/src/Common/Net/InetUtils.cs |
Decomposes network-address selection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bart-vmware
commented
Sep 29, 2026
bart-vmware
marked this pull request as ready for review
September 29, 2026 13:28
bart-vmware
force-pushed
the
fix-S3776-cognitive-complexity
branch
from
September 29, 2026 14:34
096b74c to
ffee631
Compare
bart-vmware
added
Type/infrastructure
ReleaseLine/4.x
TimHess
requested changes
Sep 29, 2026
|
TimHess
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #935.
Quality checklist
If your change affects other repositories, such as Documentation and/or Samples, add linked PRs here.