Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Oct 19, 2026
ugcodrr
force-pushed
the
fix/image-download-timeout
branch
from
November 2, 2026 00:30
da3a900 to
ec764e6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Image downloads (skins, heads, badges, capes and Mojang textures) had no timeout, so one hung download left the whole command waiting forever.
#989 is stacked on this PR.
Testing: point
loadImageat a local server that accepts but never answers. It rejects with "timeout of 5000ms exceeded" after about 5 seconds.