Skip to content

fix(progression): throw on exp outside the xp bar - #956

Open
ugcodrr wants to merge 5 commits into
mainfrom
fix/xp-bar-bounds
Open

ugcodrr wants to merge 5 commits into
mainfrom
fix/xp-bar-bounds

Conversation

@ugcodrr

@ugcodrr ugcodrr commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Description: Exp outside the xp bar threw a RangeError that only said "Invalid count value", and a slightly negative exp just drew an empty bar with no error at all.

Testing: /bedwars anrie and /skywars anrie still draw the bar like before.

@vercel

vercel Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
statsify Ignored Ignored Nov 5, 2026 12:36am UTC

@jacobk999

Copy link
Copy Markdown
Member

For this, it might be better if the command just error'd out since that way we could get a notification that something is broken. Meanwhile, here a negative exp could go exist forever without us knowing.

@jacobk999
jacobk999 marked this pull request as draft November 1, 2026 17:07
@vercel

vercel Bot commented Nov 3, 2026

Copy link
Copy Markdown

Deployment failed for project statsify with the following error:

Resource is limited - try again in 1 day (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/statsify-net?upgradeToPro=build-rate-limit

@ugcodrr ugcodrr changed the title fix(progression): keep xp bar segments within the bar fix(progression): throw on exp outside the xp bar Nov 5, 2026
@ugcodrr
ugcodrr marked this pull request as ready for review November 5, 2026 04:40
@ugcodrr

ugcodrr commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

This could also be converted/updated into a PR that improves error handling etc. Maybe after the #1054 stack merges; as well as PostHog?

This branch was previously deployed

1 inactive (outdated) deployment
Preview — a79d7ada Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants