Skip to content

fix(schemas): remove Zombies' overall fastest win and its leaderboard #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ugcodrr wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(schemas): remove Zombies' overall fastest win and its leaderboard #1012

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
657502d
fix(schemas): remove Zombies' overall fastest win and its leaderboard
ugcodrr Oct 21, 2026
e4cc892
Remove outdated comment on zombies overall wins
ugcodrr Oct 21, 2026
0e9a628
refactor(schemas): require a map for Zombies map stats
ugcodrr Oct 22, 2026
37cf2b4
chore(repo): sync PR 1012 with main and tracked public assets
ugcodrr Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 34 additions & 5 deletions packages/schemas/src/player/gamemodes/arcade/mode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1392,8 +1392,8 @@ export class ZombiesMapDifficulty {
@Field()
public totalRounds: number;

public constructor(data: APIData, map?: string, difficulty?: string) {
const mode = map ? `_${map}${difficulty ? `_${difficulty}` : ""}` : "";
public constructor(data: APIData, map: string, difficulty?: string) {
const mode = `_${map}${difficulty ? `_${difficulty}` : ""}`;

this.wins = data[`wins_zombies${mode}`];
this.fastestWin = (data[`fastest_time_30_zombies${mode}`] ?? 0) * 1000;
Expand All @@ -1418,7 +1418,7 @@ export class ZombiesMap {
@Field()
public overall: ZombiesMapDifficulty;

public constructor(data: APIData, map?: string) {
public constructor(data: APIData, map: string) {
this.normal = new ZombiesMapDifficulty(data, map, "normal");
this.hard = new ZombiesMapDifficulty(data, map, "hard");
this.rip = new ZombiesMapDifficulty(data, map, "rip");
Expand All @@ -1436,9 +1436,38 @@ export class ZombiesMap {
}
}

export class ZombiesOverall {
@Field({ historical: { enabled: false } })
public wins: number;

@Field({ leaderboard: { enabled: false } })
public kills: number;

@Field({ leaderboard: { enabled: false } })
public deaths: number;

@Field({ leaderboard: { enabled: false } })
public bestRound: number;

@Field()
public doorsOpened: number;

@Field()
public totalRounds: number;

public constructor(data: APIData) {
this.wins = data.wins_zombies;
this.kills = data.zombie_kills_zombies;
this.deaths = data.deaths_zombies;
this.bestRound = data.best_round_zombies;
this.doorsOpened = data.doors_opened_zombies;
this.totalRounds = data.total_rounds_survived_zombies;
}
}

export class Zombies {
@Field()
public overall: ZombiesMapDifficulty;
public overall: ZombiesOverall;

@Field()
public deadEnd: ZombiesMap;
Expand All @@ -1453,7 +1482,7 @@ export class Zombies {
public prison: ZombiesMap;

public constructor(data: APIData) {
this.overall = new ZombiesMapDifficulty(data);
this.overall = new ZombiesOverall(data);
this.deadEnd = new ZombiesMap(data, "deadend");
this.badBlood = new ZombiesMap(data, "badblood");

Expand Down
Loading