Repository navigation
Bump CoreJvm -> 2.0.0-SNAPSHOT.571 - #801
Merged
Merged
Conversation
Raise the `CoreJvm` pin to the latest snapshot published in the Artifact Registry: `2.0.0-SNAPSHOT.567` -> `.571`. `CoreJvm` bundles six artifacts under one `version` constant, so the pin moves only to a version published for all of them. `.571` is present for `spine-core`, `spine-client`, `spine-server`, and the `core-`, `client-`, and `server-testlib` artifacts alike. The `.571` POMs depend on the Base, BaseTypes, Change, Logging, Reflect, TestLib, Time, and Validation versions already pinned here, so no other `local/` object needs to move. `CoreJvmCompiler` stays at `.097`, which is still the newest version of both its artifacts and of its plugin marker. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
🟢 Approved
The single-constant update has no identified issues, with successful six-artifact resolution and static analysis reported in the PR.
No open issues 🎉
What changed in this PR
Updates the shared CoreJvm dependency pin to prevent config pulls from downgrading consumer repositories.
Changes:
- Raises all six CoreJvm artifact coordinates from
2.0.0-SNAPSHOT.567to.571. - Leaves CoreJvmCompiler unchanged at
.097.
| File | Description |
|---|---|
buildSrc/src/main/kotlin/io/spine/dependency/local/CoreJvm.kt |
Updates the shared CoreJvm version constant. |
Review effort: Balanced
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the stale
CoreJvmpin to the newest snapshot published in the SpineArtifact Registry:
2.0.0-SNAPSHOT.567→2.0.0-SNAPSHOT.571.Because
./config/pullcopiesbuildSrc/wholesale, a stale pin here activelydowngrades any consumer repo that has already moved ahead, which then has to
restore the file by hand after every pull.
Picking the version carefully
CoreJvmis not a single artifact — it bundles six published artifactsunder one
versionconstant, across two groups:io.spinespine-core,spine-client,spine-serverio.spine.toolscore-testlib,client-testlib,server-testlib(The deprecated
testUtilServeris a seventh constant reusingserver-testlib.)Taking the newest version of
spine-corealone can pin something the otherfive never published, which fails at resolution time in every consumer. So each
artifact's
maven-metadata.xmlwas queried separately and the pin moved to thehighest version present in all six —
.571.CoreJvmCompilerstays at.097Both of its artifacts (
core-jvm-gradle-plugin,core-jvm-plugins) and theio.spine.core-jvmplugin marker still top out at2.0.0-SNAPSHOT.097, whichis already what it pins for
versionanddogfoodingVersion. Nothing to move,so the build-script pin is not raised past what the build can resolve.
Verification
confighas no rootversion.gradle.kts, so the version-bump gate does notapply; it also has no
buildtask and registers no Dokka tasks../gradlew detekt— the command CI gates on — passes.java-libraryproject(
mavenCentral()plus thereleasesandsnapshotsArtifact Registryrepos, the six coordinates as
implementation, resolvingruntimeClasspath),since
buildDependantsis currently broken onmasterby a relative-pathbug in
config-tester.gradle.kts. All six resolve at.571; 70 files on theclasspath.
local/pins exactly —base
.460, base-types.225, change.208, logging.425, reflect.201,base-testlib
.214, time.251, validation.464. So the bump bringsCoreJvminto lockstep with the rest oflocal/rather than racing aheadof it, and no sibling pin needs to move.
.571alongside the pins from Raise stalelocal/dependency pins #799(base
.461, logging.426, reflect.202, base-testlib.215) alsoresolves cleanly, so the two PRs compose and can land in either order.
Reviewed by
dependency-audit,spine-code-review, andkotlin-engineer.🤖 Generated with Claude Code