Skip to content

Drop the force on the unpublished tool-base artifact - #56

Merged
alexander-yevsyukov merged 3 commits into
masterfrom
drop-unpublished-tool-base-force
Oct 19, 2026
Merged

alexander-yevsyukov merged 3 commits into
masterfrom
drop-unpublished-tool-base-force

Conversation

@alexander-yevsyukov

Copy link
Copy Markdown
Contributor

base-types at master no longer compiled against config at master. Its
root build.gradle.kts referenced io.spine.dependency.local.ToolBase.lib,
which config no longer declares, so the build script failed with
Unresolved reference 'lib'.

This was found by the buildDependants task in config, which had just been
repaired in SpineEventEngine/config#805 and could finally reach its consumers.

Which side was wrong

config's side was deliberate, so the fix belongs here. ToolBase.lib was
removed by SpineEventEngine/config@2570f27e, whose message says so outright:

Remove the deprecated ToolBase.lib: the tool-base artifact is no longer
published. Keep the explanation in the ToolBase KDoc.

The constant had been marked @Deprecated with a migration note before it was
dropped, and the surviving ToolBase KDoc still records that the all-in-one
io.spine.tools:tool-base artifact stopped being published as of
2.0.0-SNAPSHOT.420, its contents having been split across focused modules.

The change

One line deleted from the force(...) list in the root build script.

Nothing replaces it, because the entry was dead.

force(...) inside a resolutionStrategy only pins a version for a module
that is already in the graph; it never adds one. And the version it pinned did
not exist: in the buildSrc vendored here, ToolBase.version is
2.0.0-SNAPSHOT.421, while the highest tool-base ever published is
2.0.0-SNAPSHOT.410. So had tool-base been in any graph this force applied
to, resolution on master would already fail with "could not find
tool-base:421". master is green, so the entry was unreachable, and deleting
it can only turn a latent failure into a successful resolution.

No focused module is added in its place. Forcing a module that is not in a
graph does nothing, and none of archive, code, fs, java-code,
kotlin-code or proto-code shows up in the resolved reports; adding them
would pin modules with no demonstrated version conflict. The focused modules
the list already forces — gradlePluginApi, jvmTools, pluginBase,
protobufSetupPlugins and psiJava — cover what tool-base was split into.

The deleted line was also the last consumer of a @Deprecated constant in the
buildSrc currently vendored here, so the configuration phase loses a
deprecation warning as well.

Every remaining constant in that list exists both in the vendored buildSrc
and in config at master, so the build script now compiles against either.
The change does not require pulling the new config first.

Verification

Reproduced and confirmed with config's own integration task rather than by
hand — ./gradlew clean buildDependants, run from a config worktree at the
#805 branch, which clones each consumer and overlays the local config:

repository before after
base pass pass
base-types fail — Unresolved reference 'lib' pass
core-jvm never reached fails for an unrelated reason, below

./gradlew build also passes here against the vendored buildSrc.

About the dependency reports

Besides the version line, the regenerated reports carry drift that master had
already accumulated: poko-annotations, sarif4k and
kotlinx-serialization-core/-json appear as root artifacts whose -jvm
siblings were already listed at the same versions, and the stale
kotlin-stdlib-common/-jdk7/-jdk8 1.8.20 and
kotlinx-coroutines-core/-core-jvm 1.7.3 entries drop out.

Two things worth not chasing:

  • The kotlin-stdlib 2.1.21 -> 2.2.20 line is not an upgrade. Both are
    non-maximal transitive rows; the highest kotlin-stdlib in the report stays
    2.4.10, matching Kotlin.runtimeVersion. No artifact's maximum version
    decreased.
  • The kotlin-stdlib license string changing from "The Apache License, Version
    2.0" to "Apache-2.0" comes from upstream POM metadata and is cosmetic.

None of it follows from this branch. Regenerating the reports at master with
no source change at all reproduces exactly the same drift, so it is the
committed report that was stale.

Version

2.0.0-SNAPSHOT.225 -> .226. Note that .225 is both what master declared
and what Artifact Registry already holds, so .224 would have collided with a
published snapshot.

Not fixed here: core-jvm

With this branch in place, buildDependants gets past base-types and then
fails in core-jvm's server-otel/build.gradle.kts on
Unresolved reference 'OpenTelemetryKotlin'.

That is the mirror image of this problem, not the same one. config has never
declared OpenTelemetryKotlin — git log -S"OpenTelemetryKotlin" over the whole
config repository returns nothing. The file exists only in core-jvm's own
copied buildSrc, added by core-jvm@e46a9a04 ("Draft server-otel module")
and never upstreamed, so replacing buildSrc wholesale makes it disappear.

It needs its own change in config or in core-jvm, and is left out of this PR
deliberately.

🤖 Generated with Claude Code

alexander-yevsyukov and others added 3 commits October 19, 2026 14:53
`config` no longer declares `io.spine.dependency.local.ToolBase.lib`: the
all-in-one `io.spine.tools:tool-base` artifact stopped being published as of
`2.0.0-SNAPSHOT.420`, and the constant was removed from `ToolBase` in
SpineEventEngine/config@2570f27e. The root build script still referenced it in
the `force(...)` list, so it no longer compiles against `config` at `master`.

The entry was vestigial. `force(...)` only pins a version for an artifact that
actually appears in a resolved graph; it never adds one. `base-types` resolves
no `io.spine.tools:tool-base` at all, and nothing can depend on an artifact
that is no longer published, so the line is removed rather than replaced. The
focused modules the list already forces -- `gradlePluginApi`, `jvmTools`,
`pluginBase`, `protobufSetupPlugins` and `psiJava` -- cover what `tool-base`
was split into.

Every remaining constant in the list exists both in the `buildSrc` currently
vendored here and in `config` at `master`, so the build script compiles against
either.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Artifact Registry already holds `2.0.0-SNAPSHOT.225`, which is also the version
`master` declares, so the next free number is `.226`.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Regenerated by `./gradlew build`. Besides the version line, the diff carries
drift that `master`'s committed report had already accumulated:
`poko-annotations` 0.17.1, `sarif4k` 0.6.0 and `kotlinx-serialization-core`
and `-json` 1.4.1 appear, `kotlin-stdlib` moves 2.1.21 -> 2.2.20, and the
stale `kotlin-stdlib-common`/`-jdk7`/`-jdk8` 1.8.20 and
`kotlinx-coroutines-core`/`-core-jvm` 1.7.3 entries drop out.

None of that follows from this branch. Regenerating the reports at `master`
with no source change at all reproduces exactly the same drift, so it is the
committed report that was stale.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 19, 2026 14:38
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T14:39:49.869586Z ab3c642 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

The removal is narrowly scoped, version metadata is consistent, and no blocking issues were identified.

No open issues 🎉

What changed in this PR

Removes the obsolete ToolBase.lib force entry so base-types remains compatible with the updated shared build configuration.

Changes:

  • Removes the unpublished artifact’s version constraint.
  • Advances the snapshot version from .225 to .226.
  • Refreshes dependency reports and publication metadata.
File Description
version.gradle.kts Sets the publication version to .226.
docs/​dependencies/​pom.xml Aligns the documented project version.
docs/​dependencies/​dependencies.md Refreshes dependency and license information.
build.gradle.kts Removes the obsolete ToolBase.lib reference.

Review effort: Balanced

@codecov

codecov Bot commented Oct 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.18%. Comparing base (f955c57) to head (ab3c642).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #56   +/-   ##
=========================================
  Coverage     94.18%   94.18%           
  Complexity       76       76           
=========================================
  Files            13       13           
  Lines           275      275           
  Branches         26       26           
=========================================
  Hits            259      259           
  Misses           12       12           
  Partials          4        4           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexander-yevsyukov
alexander-yevsyukov merged commit c322309 into master Oct 19, 2026
10 checks passed
@alexander-yevsyukov
alexander-yevsyukov deleted the drop-unpublished-tool-base-force branch October 19, 2026 14:46
@github-project-automation github-project-automation Bot moved this from In Review to ✅ Done in v2.0 Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants