Skip to content

BED-10258: Expose numeric App ID on GH_App nodes - #89

Merged
jaredcatkinson merged 1 commit into
mainfrom
fix/BED-10258-expose-github-app-id
Oct 23, 2026
Merged

jaredcatkinson merged 1 commit into
mainfrom
fix/BED-10258-expose-github-app-id

Conversation

@jaredcatkinson

@jaredcatkinson jaredcatkinson commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

GH_App nodes currently omit the numeric GitHub App ID, preventing integrations such as Jenkins from correlating app credentials with the app node. Populate the existing id property from the collected App ID.

Preserve the graph Object ID, node_id, client_id, and existing GH_InstalledAs relationships. Apps with null or omitted App IDs remain supported.

Ticket: BED-10258.

Validation: exercised the edited model in the published collector container with networking disabled. Verified serialized output for numeric, null, and omitted App IDs; confirmed graph identity and client ID remain intact and GH_InstalledAs still references the unchanged app identifier. git diff --check passed.

Summary by CodeRabbit

  • Bug Fixes
    • App installation information now includes the associated app identifier alongside the app’s other details. This makes the identifier available wherever those properties are surfaced, providing more complete app information. No other user-facing changes are included in this update.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 2c03a0b1-2f6d-464b-8d45-7a93e3c2fc57
📥 Commits

Reviewing files that changed from the base of the PR and between e4ae9aa and df78c2d.

📒 Files selected for processing: 1
  • src/openhound_github/models/app_installation.py

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Walkthrough

App.as_node now passes the App model’s ID to the constructed GHAppProperties.

Changes

App Node ID Propagation

Layer / File(s) Summary
Pass ID to GHAppProperties
src/openhound_github/models/app_installation.py
App.as_node now supplies self.id as the id property of GHAppProperties.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to df78c

The change is mergeable based on the supplied evidence.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: exposing the numeric GitHub App ID on GH_App nodes.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit hops past rows of code,
And finds an ID along the road.
It tucks the value in its place,
Then bounds away at rabbit pace.
The app node wears its ID with grace.

Comment @coderabbitai help to get the list of available commands.

@jaredcatkinson
jaredcatkinson merged commit ce88b7f into main Oct 23, 2026
3 checks passed
@jaredcatkinson
jaredcatkinson deleted the fix/BED-10258-expose-github-app-id branch October 23, 2026 20:16

This branch was successfully deployed

1 active deployment
pypi — df78c2d7 Deployed Oct 23, 2026 by jaredcatkinson via publish / build #63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants