Skip to content

feat: Collect dMSA patch prerequisites from domain controllers - #235

Draft
adilalperenciftci wants to merge 1 commit into
SpecterOps:2.Xfrom
adilalperenciftci:fix/dmsa-badsuccessor-hardening
Draft

adilalperenciftci wants to merge 1 commit into
SpecterOps:2.Xfrom
adilalperenciftci:fix/dmsa-badsuccessor-hardening

Conversation

@adilalperenciftci

@adilalperenciftci adilalperenciftci commented Oct 25, 2026 •

Copy link
Copy Markdown

Problem

The dMSA analysis pipeline requires domain controller build and update-revision values, but the runtime does not currently invoke the corresponding registry collection added in SpecterOps/SharpHoundCommon#321.

Solution

I add CurrentBuildNumber and CurrentBuildRevision to the existing DCRegistryData collection. Both values use the established DCRegistry collection boundary, so default collection behavior and non-DC processing remain unchanged.

This is the runtime companion to SpecterOps/SharpHoundCommon#321 and SpecterOps/BloodHound#3583.

Testing

  • dotnet msbuild Sharphound.csproj -t:Compile -p:Configuration=Release -p:CommonSource=Local -p:DisableFody=true

@coderabbitai

coderabbitai Bot commented Oct 25, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@adilalperenciftci

Copy link
Copy Markdown
Author

recheck

1 similar comment
@adilalperenciftci

Copy link
Copy Markdown
Author

recheck

@adilalperenciftci

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@adilalperenciftci

Copy link
Copy Markdown
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant