Repository navigation
feat: Collect dMSA patch prerequisites from domain controllers - #235
Draft
adilalperenciftci wants to merge 1 commit into
Draft
adilalperenciftci wants to merge 1 commit into
adilalperenciftci wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
recheck |
1 similar comment
Author
|
recheck |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dMSA analysis pipeline requires domain controller build and update-revision values, but the runtime does not currently invoke the corresponding registry collection added in SpecterOps/SharpHoundCommon#321.
Solution
I add
CurrentBuildNumberandCurrentBuildRevisionto the existingDCRegistryDatacollection. Both values use the establishedDCRegistrycollection boundary, so default collection behavior and non-DC processing remain unchanged.This is the runtime companion to SpecterOps/SharpHoundCommon#321 and SpecterOps/BloodHound#3583.
Testing
dotnet msbuild Sharphound.csproj -t:Compile -p:Configuration=Release -p:CommonSource=Local -p:DisableFody=true