Repository navigation
Conversation
|
Important Review skippedToo many files! This PR contains 427 files, which is 277 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to Team to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configuration
⛔ Files ignored due to path filters: 1
📒 Files selected for processing: 427
You can disable this status message by setting the
Comment |
zinic
force-pushed
the
pg-v2
branch
3 times, most recently
from
August 25, 2026 21:06
3609d9e to
5149abc
Compare
zinic
force-pushed
the
pg-v2
branch
2 times, most recently
from
September 8, 2026 21:37
e3ff391 to
bf50f00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR delivers the PostgreSQL traversal/runtime work as a complete, validated stack:
drivers/pg/v2package with the finalized connection-local runtime indrivers/pg.pg.NewPoolremains the caller-owned pool constructor and installs lifecycle hooks.*pgxpool.Pooltopg.NewDriverordawgs.Open.Benchmark deltas vs
mainCompared
main(9c2f496) with this branch (cd975e4) for the two shared benchmark datasets,baseandtraversal_shapes. Each side used two 50-iteration captures per scenario, one warm-up, and one worker. Negative deltas are faster.All 21 shared scenarios improved. These are cumulative branch-vs-
mainresults, not an isolation of only the final runtime-retirement commit.Type of Change
Testing
make test_allwithCONNECTION_STRINGset)Full suites were run successfully against both supplied PostgreSQL and Neo4j targets. Focused race tests for
./cmd/benchmarkand./drivers/pg, generated-test updates, linting, formatting, and diff checks also passed.Screenshots (if appropriate):
N/A
Driver Impact
drivers/pg)drivers/neo4j)Checklist
go.mod/go.sumare up to date if dependencies changed