Skip to content

Skip GraphStore resource compatibility checks for custom launchers - #782

Merged
kmontemayor2-sc merged 1 commit into
mainfrom
codex/custom-launcher-graph-store-validation
Sep 30, 2026
Merged

kmontemayor2-sc merged 1 commit into
mainfrom
codex/custom-launcher-graph-store-validation

Conversation

@kmontemayor2-sc

Copy link
Copy Markdown
Collaborator

Summary

Custom launchers own their resource configuration, but GraphStore validation currently requires built-in resource pools even when a custom launcher is selected.

Skip this compatibility check independently for custom trainer and inferencer launchers. Built-in components retain their existing validation, including in mixed configurations.

Verification

  • Regression test reproduced the failure before the fix.
  • All 10 compatibility tests pass through the project test runner.
  • Full type checking and Python/Markdown formatting checks pass.
  • Commit and push hooks pass.

@yliu2-sc yliu2-sc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmontemayor2-sc
kmontemayor2-sc marked this pull request as ready for review September 29, 2026 23:53
@kmontemayor2-sc
kmontemayor2-sc added this pull request to the merge queue Sep 29, 2026
Merged via the queue into main with commit 0f11bf0 Sep 30, 2026
7 checks passed
@kmontemayor2-sc
kmontemayor2-sc deleted the codex/custom-launcher-graph-store-validation branch September 30, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants