Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SkyeAv
added this pull request to stack #170
September 15, 2026 17:40
This was referenced Sep 15, 2026
SkyeAv
marked this pull request as ready for review
September 15, 2026 18:07
Add a stdlib-only transient classifier and bounded jittered retry driver for DNS, socket, HTTP, and gateway failures. Reuse the classification table for BABEL downloads, preserve network errno retries, make retry logs safe for the enqueueing logger, and document the new module. Add offline coverage for fleet failure classes, retry budgets, and download behavior.
SkyeAv
added a commit
that referenced
this pull request
Sep 15, 2026
Cut 19.0.0 and bump the package version in pyproject.toml, CITATION.cff, and uv.lock. Major: five breaking changes ship. The `tablassert` console command now requires the optional `[cli]` extra, since `cyclopts` and `rich` left the base install (#187). Level-one normalization redefines fullmap keys as cleaned Unicode-lowercase, Porter2-normalized, byte-ordered token sets and moves the database to schema v6, so every schema-v5 fullmap is rejected and must be rebuilt (#171, #172, #174, #175, #176). `build-fullmap --aria2c` is gone -- aria2c is used automatically whenever the `[aria2]` extra is installed (#178) -- and `--taxon-allowlist` is gone because the built-in top-100 experimental-taxon allowlist now applies to every build, guarding both reuse paths by `META.taxon_allowlist` identity (#153). Logging now requires the `[log]` extra and is fully disabled without it (#152). Features: `tablassert.net` is a new stdlib-only transient/permanent classification and retry seam shared by the agent and the BABEL downloader (#163, #164), with one bounded jittered retry layer across the inner agent, reflexion, and judge (#167) and machine-readable `error_code` values on skipped checkpoint records (#166). `build-kg` gained an automatic ephemeral shared-prefix TCode cache keyed by content-addressed XXH64 op digests (#155-#159, #161). The `--distill` corpus became schema-uniform v2 with a sibling `outcomes.ndjson`, a deterministic `RewardConfig`-tunable reward, and the new zero-dependency `tablassert distill-weigh` command (#180-#183). `CLASS_FIELD_OVERRIDES` grants the DAKP sparse qualifier stack on the pinned association classes (#188). Fixes: `distill-export` partitions its corpus by content and unions the schema across record files, so a mixed v1/v2 directory no longer CastErrors or silently stringifies a column (#184); BABEL retry warnings survive the loguru sink; PMC downloads are idempotent, atomic, and bounded-parallel (#165); reflexion and judge prompts are hard-bounded (#168). Changelog: - versioned the Unreleased section as 19.0.0 - 2026-09-15 - merged three duplicate `### Added` blocks into one - moved the two `BREAKING:` entries from `### Changed` into `### Breaking Changes` and added a `**Migration:**` note to all five - added PR links to all 17 entries, which carried none - added the missing entries: the distill v2 corpus/reward/distill-weigh stack (#180-#183), the distill-export schema-drift fix (#184), the TCode run-cache detail (#155-#161), and the README badge removal (#154) Docs: none needed here. Every shipped doc change landed with its own PR, and the docs source-of-truth gate passes against the bumped tree. Testing: - make check -> exit 0 - uv run ruff check . -> All checks passed! - uv run pyright -> 0 errors, 0 warnings, 0 informations - uv run pytest -> 1622 passed, 52 skipped - cargo test --manifest-path rust/Cargo.toml -> 156 passed, 0 failed - cargo clippy --all-targets -- -D warnings -> clean - uv lock --check -> resolved 169 packages, lock current - uv run mkdocs build --strict -> exit 0 - docs SSOT + CLI coverage after the changelog edit -> 204 passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
src/tablassert/net.py, a stdlib-only network-resilience seam that classifies each failure as transient or permanent and retries transient ones with bounded jittered backoff — and rewires BABEL downloads onto it. Fleet motivation: a 16-worker run over 42,981 PMC articles lost 2,194 of 2,507 queue failures (87.5%) to DNS-shaped errors ([Errno -2] Name or service not known) during a resolver-outage burst; single-attempt fetches turned a recoverable blip into a terminal skip.Classification
net.is_transient: DNS (URLErrorwrappingsocket.gaierror), connection loss, timeouts, HTTP408/425/429and every 5xx, bareOSErrors with network errnos, and optional-library exceptions (openai/litellm/httpx) matched by name — never imported — are transient.ValueError/TypeError/KeyError, non-CC-licensePermissionError, no-OA-filesFileNotFoundError, other 4xx, and local-errnoOSErrors (ENOSPC,EACCES) fail fast.__bool__/__cause__/errnocannot break classification;__cause__/__context__are walked (≤ 3 links) so library wrappers keep their code.Retry driver
net.retry_transient: 4 attempts, 1.0 s base doubling to 20.0 s, sleeps summing to ≤ 60.0 s;Retry-Afterheaders and(reset after …)quota hints set the wait (max(hint, jittered step)), capped at 60 s. Exhaustion raises a codedNetworkTransientError(network-transient).BABEL rewire
cli.download_babel_filedrops its hand-rolled predicate fornet.is_transient. Three intentional, test-pinned deltas:425now retried; permanent localOSError(ENOSPCon.part) fails fast instead of burning 5 attempts / 75 s; bare network-errnoOSErrorkeeps the 5-attempt guarantee. Range resume, streaming, and theretries=5schedule unchanged.error=str(e)— theenqueue=Truesink silently dropped lines binding rawHTTPErrorobjects (unpicklableBufferedReader).Design
tablassert.cli, which installs without the[agent]extra —tenacity/urllib3.util.retrywould land in the base install.docs/api/net.mdpage (theerrors.DOCS_URLremediation is tracked as a separate project in 18.0.0's changelog).Testing
uv run pytest tests/test_net.py -q --no-cov -n 0→29 passed in 0.08suv run pytest tests/test_cover_cli.py -q --no-cov -n 0→ all pass (BABEL classification deltas pinned)uv run pytest -q→1565 passed, 15 skipped;uv run ruff check ./ruff format --check .→ clean;uv run pyright→0 errors;make test-rust+cargo clippy --manifest-path rust/Cargo.toml --all-targets -- -D warnings→ clean--durations=10max 0.17 s); independent Tier-2 review passed after two repair rounds (regex classification, loguru pickling).