Repository navigation
Build against the current discord-framework - #11
Merged
Merged
Conversation
TicketBot stopped compiling when the framework moved NerdBotConfig into the NerdBot app and changed SchedulableFeature to take the base DiscordBotConfig and run executeTask() itself. The features now take DiscordBotConfig, and feature loading schedules them the same way NerdBot does, with their own default timings instead of passing null and falling back to hard-coded ones.
discord-framework now loads the features listed in the config itself (createConfiguredFeatures) and keeps the features list in DiscordBotConfig. TicketBot's own copy of the loader and of the field go, and the field has to: Gson refuses a subclass field with the same name as one in its parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TicketBot has stopped compiling against NerdBot's discord-framework since the July framework changes. This brings it up to date. It builds and passes against the current JitPack framework snapshot (
master-5582a8dce8-1).Changes
NerdBotConfigmoved into the NerdBot app. TicketBot's features now take the framework'sDiscordBotConfig.SchedulableFeaturenow schedules features itself. The ticket features use their own default timings instead of passingnulland falling back to hard-coded ones.createConfiguredFeatures), and keeps thefeatureslist onDiscordBotConfig.featuresfield goes too, and it has to: Gson refuses a subclass field with the same name as one in the parent.Before deploying
The config's
featuresentries keep the same shape. Feature class names must still start withnet.hypixel.nerdbot., which the ticket features already do.