Conversation
loadMicropolisMainModule passed Module.wasmBinary. Emscripten accepts
that option only when wasmBinary is listed in INCOMING_MODULE_JS_API, and
the current default list omits it, so a build made with the current
Emscripten aborted before anything ran:
RuntimeError: Aborted(`Module.wasmBinary` was supplied but
`wasmBinary` not included in INCOMING_MODULE_JS_API)
The committed artifacts predate that default, so the failure appears only
once `make install` regenerates them. The loader now takes the wasm from
locateFile, which reads micropolisengine.wasm from disk next to the glue.
This was referenced Sep 29, 2026
jquast
marked this pull request as ready for review
September 29, 2026 17:14
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
micropolis sim smokefails by abort aftermake:The glue aborts for any incoming module property the build left out of
INCOMING_MODULE_JS_API, andwasmBinaryis one. The committed artifacts came from a build whose list still had it, so this shows up aftermake clean installreplaces them. The glue loads the wasm throughlocateFile('micropolisengine.wasm'), so the loader's threewasmBinarylines are dead weight and removed.Existing PRs #12 and #14 fix the same abort by declaring
wasmBinaryinINCOMING_MODULE_JS_API; this patch changes only the loader.The loader also passed
printandprintErras no-ops, so the engine's own output never reached the terminal. Both now follow the global-vflag, which subsequent PR fixes need to confirm their fixes: