chore(deps): resolve the TrueHD object decoder from LibTrueHD 2.0.0 by Quick104 · Pull Request #19 · Silo-Server/AetherEngine

Quick104 · 2026-10-11T15:05:17Z

Summary

SiloObjectAudio, the TrueHD object decoder behind objectAudioRendering, now lives at superuser404notfound/LibTrueHD after Silo transferred it (superuser404notfound#731). Release 2.0.0 renames the package to LibTrueHD and the product, module and xcframework to TrueHD. This points the fork at the new package. The decoder and its truehd_atmos_ C API are unchanged, so the only code change is the import.

The old Silo-Server/SiloObjectAudio URL still redirects, so the current pin keeps resolving; this moves the fork to the maintained name.

Related: superuser404notfound#731

What changed

Package.swift depends on superuser404notfound/LibTrueHD from 2.0.0 up to the next minor, product TrueHD.
TrueHDObjectAudioDecoder.swift imports TrueHD, and its doc comment names LibTrueHD.
Package.resolved pins libtruehd 2.0.0 (7ac6b379) in place of siloobjectaudio 1.0.0.
CHANGELOG.md has an Unreleased entry.

It stays on 2.0.0, upstream's rebuild of the decoder this fork already ships, so this PR changes the name and nothing else. LibTrueHD 2.1.0 (x86_64 in the iOS simulator slice) and 2.2.0 (about 30% faster decoding on a newer truehd pin) are a separate update, as is syncing the fork to upstream 7.34.0, which ships upstream's port of the object rendering.

Test plan

Device / OS: macOS 27 with Xcode 27 (swift build, swift test).
Source media: Dolby's "Unfold" demo, TrueHD Atmos 7.1 (LFE + 15 objects), through TrueHDAtmosSampleTests.
Result:
- swift build passed.
- The full suite in its two CI groups passed: 4,149 tests in 573 suites, and 56 tests in 5 suites.
- TrueHDAtmosSampleTests decoded 1,298,000 frames with LFE + 15 objects, and all four height channels of the 7.1.4 render carry level.
- Silo's iOS, tvOS and macOS apps build against this revision and link all 13 truehd_atmos_* functions (chore(deps): take the TrueHD Atmos decoder from LibTrueHD 2.0.0 silo-apple#725).

Evidence: https://evidence.siloserver.org/r/aetherengine/pr-19/

Merge note

The Silo app's matching PR, Silo-Server/silo-apple#725, pins this branch's commit fa70ab5b. Please merge with a merge commit, as #17 was, so that commit lands on main. A squash or rebase merge would leave the app pinned to a commit outside main until it is repinned.

Checklist

CHANGELOG.md updated
Commit messages follow Conventional Commits (feat(...), fix(...), chore(...))
The fix lives in the engine, not in a host-side workaround
Public API changes are intentional and documented (none)

AI Disclosure

Harness: Claude Code (running in T3 Code)
Tool(s): Claude Code
Model(s): claude-opus-5-5
Involvement: Fully AI-generated, pending human review
Adversarial review: n/a

🤖 Generated with Claude Code

SiloObjectAudio moved to superuser404notfound/LibTrueHD (AE#731) and was renamed for 2.0.0: package LibTrueHD, product, module and xcframework TrueHD. The decoder source and its truehd_atmos_ C API are unchanged, so only the package reference, the import and the lock move. Verified on macOS (Xcode 27): swift build, the full test suite in its two CI groups, and TrueHDAtmosSampleTests against Dolby's Unfold demo (1,298,000 frames, LFE + 15 objects, signal in all four height speakers of the 7.1.4 render). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

silo-kody · 2026-10-11T15:05:25Z

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo

Include the related issue, expected behavior, and validation steps in the PR description.
For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
Follow this repository's AGENTS.md and CONTRIBUTING.md.
Request another review with @kody start-review in a PR comment.
React with 👍 or 👎 to give feedback on individual suggestions.

Review settings

Review Options

The following review options are enabled or disabled:

Options	Enabled
Bug	✅
Performance	✅
Security	✅
Business Logic	❌

chatgpt-codex-connector · 2026-10-11T15:05:32Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-11T15:07:04.087323Z	`fa70ab5`	PR opened
🔒 Security Review	✅ Completed 2026-10-11T15:08:29.438992Z	`fa70ab5`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-10-11T15:05:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 8b00d4d6-a0d5-4c91-b168-934ff314a684

📥 Commits

Reviewing files that changed from the base of the PR and between ef0d2c7 and fa70ab5.

⛔ Files ignored due to path filters (1)

Package.resolved is excluded by !**/Package.resolved

📒 Files selected for processing (3)

CHANGELOG.md
Package.swift
Sources/AetherEngine/Audio/Spatial/TrueHDObjectAudioDecoder.swift

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

AetherEngine now resolves its TrueHD object decoder dependency from LibTrueHD 2.0.x and imports the TrueHD module. The decoder implementation and C API are unchanged.

Changes

TrueHD dependency update

Layer / File(s)	Summary
Update decoder dependency and import `Package.swift`, `Sources/AetherEngine/Audio/Spatial/TrueHDObjectAudioDecoder.swift`, `CHANGELOG.md`	AetherEngine now uses the `TrueHD` product from LibTrueHD 2.0.x, and the decoder imports `TrueHD`. The changelog records the dependency update and states that the decoder and C API are unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: brandomoore

Merge Risk: ⚪ Minimal · up to fa70a

The dependency integration matches the decoder’s expected module and API, with no concrete merge-blocking risk identified.

Pre-merge checks | 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description check		The description directly explains the dependency move from SiloObjectAudio to LibTrueHD 2.0.0, the import update, testing, and scope.
Title check		The title clearly and concisely identifies the main change: resolving the TrueHD object decoder from LibTrueHD 2.0.0.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

silo-triage Bot added the triaged High-confidence review completed; does not mean fixed, validated, or accepted for release. label Oct 11, 2026

Quick104 mentioned this pull request Oct 11, 2026

chore(deps): take the TrueHD Atmos decoder from LibTrueHD 2.0.0 Silo-Server/silo-apple#725

Merged

2 of 3 tasks

Quick104 merged commit bc63849 into main Oct 11, 2026
3 checks passed

Navigation Menu

Repository navigation

chore(deps): resolve the TrueHD object decoder from LibTrueHD 2.0.0 - #19

chore(deps): resolve the TrueHD object decoder from LibTrueHD 2.0.0#19
Quick104 merged 1 commit into
mainfrom
chore/libtruehd

Quick104 commented Oct 11, 2026 •

edited

Loading

Uh oh!

silo-kody Bot commented Oct 11, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 11, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 11, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Quick104 commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What changed

Test plan

Merge note

Checklist

AI Disclosure

Uh oh!

silo-kody Bot commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Silo Kody — review complete

Uh oh!

chatgpt-codex-connector Bot commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Quick104 commented Oct 11, 2026 •

edited

Loading

silo-kody Bot commented Oct 11, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 11, 2026 •

edited

Loading

coderabbitai Bot commented Oct 11, 2026 •

edited

Loading