Skip to content

Keep commit syncs working when GitHub author profiles are unavailable - #1512

Open
efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/shipit-bot-author-fallback
Open

efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/shipit-bot-author-fallback

Conversation

@efegokdemir

Copy link
Copy Markdown

Some GitHub commit authors have a profile link that returns 404, which makes GithubSyncJob mark the stack inaccessible. This keeps the commit payload when the profile lookup fails, allowing the existing login fallback to populate the name, and adds a regression test. ruby -c, a standalone smoke test, and git diff --check passed; the focused Minitest command could not run because the locked dependencies are missing locally. Fixes #1411.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copilot coding agent breaks commit syncs

1 participant