Repository navigation
Validate fabric-length pricing in cart transform sample - #663
Merged
Merged
Conversation
Co-authored-by: River <river@shopify.com>
madmath
marked this pull request as ready for review
October 29, 2026 15:15
Contributor
Author
|
@stephanie-shopify could you review this change? Please see the description for compatibility questions and verification limitations. |
Fix useless_borrows_in_formatting without suppressing warnings or changing the formatted weekday value.
kirakik
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harden fabric-length pricing validation in the cart-transform sample while leaving the original price unchanged when an update is rejected.
Compatibility review needed: this retains the existing two-decimal pricing convention. Merchant-defined length minimums and allowed increments remain a separate design decision; this patch does not implement a complete merchant pricing policy.
Validation from the extension directory (Node 22.15.0):
npm test: 6/6 pass. With the new tests but without the fix, 2 fail and 4 pass.node_modules/.bin/graphql-codegen --config package.json: passes.node_modules/.bin/tsc --allowJs --checkJs --noEmit --target es2020 --moduleResolution node src/run.js: passes, also with--strict(TypeScript 4.9.5).npm run build: blocked before Wasm compilation by duplicate GraphQL modules, on both original and patched code. Wasm output is unverified.git diff --check: passes. Full repository suites were not run.CI follow-up: fe6b0c2 removes a redundant borrow in the pickup-point Rust sample without changing behavior. Rust CI, JavaScript, TypeScript, and CLA checks all pass on the updated head. Local formatting and the six JavaScript sample tests also pass; local Rust compilation was blocked by dependency build scripts receiving
SIGKILL.