Repository navigation
Fix sampler list recovery after app process recreation - #738
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #622.
Restore AUTOMATIC1111 sampler loading after app process recreation. Both generation screens now show loading and localized failure feedback, offer Retry, and retry missing samplers when the app resumes.
Scope cached samplers to the server URL and credentials, serialize cache replacement and reads, and cancel obsolete screen requests. A populated cache remains available during transient server failures; an empty cache no longer hides a failed fetch.
Checklist
Tested On
Verified process recreation, HTTP 503 and empty responses, failed and successful retries, foreground recovery, delayed loading, and valid cache fallback. Android full debug assembly, iOS Simulator Kotlin compilation, focused domain/data/presentation unit tests, and whitespace checks passed. Three independent adversarial review passes completed without outstanding findings after repairs. Live AUTOMATIC1111 and iOS runtime behavior were not tested.
Automated regression coverage
Executed
:domain:testDebugUnitTest --tests '*GetStableDiffusionSamplersUseCaseImplTest',:data:testDebugUnitTest --tests '*StableDiffusionSamplers*Test', and:presentation:testDebugUnitTest --tests '*GenerationSamplersViewModelTest'. These exercise production use cases, repository, and view models with controlled dependencies; OS process recreation and foreground lifecycle wiring were checked separately through the Android app as described above.