Repository navigation
fix: KimiLinear MLP applies silu to gate_proj, not up_proj - #257
Merged
Merged
Conversation
SwiGLU is down(silu(gate(x)) * up(x)); the code had silu on up_proj. Adds a hand-computed SwiGLU regression test (KimiMLP made internal for @testable access). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
KimiMLPcomputeddown(gate(x) * silu(up(x))). SwiGLU isdown(silu(gate(x)) * up(x)): the activation belongs ongate_proj. The old form has no shape error, so it silently produces wrong activations for every KimiLinear MLP layer.One-line fix in
Sources/SwiftLM/KimiLinearDFlash.swift;KimiMLPis madeinternalso the test can use@testable.Test
tests/SwiftLMTests/KimiLinearMLPTests.swiftbuilds the MLP with fixed, non-symmetric weights and compares against a hand-computed SwiGLU.Run locally (this branch with
mainmerged in,69bc71c):swift test --filter KimiLinearMLPTests: 1 test, 0 failures,EXIT=0.Tracks SL-63 / the KimiLinear item in #254.
🤖 Generated with Claude Code