Repository navigation
chore(deps): vendor the hREA GraphQL adapter 0.700.0-rc.0 into the UI - #155
Merged
Merged
Conversation
Commit the @valueflows/vf-graphql-holochain 0.700.0-rc.0 tarball built from h-REA/hREA tag happ-0.5.0-beta.1 (79c8d4fb) under vendor/, beside the hrea submodule, with its sha256 and a README recording source commit, rebuild steps and how to drop it once npm serves 0.700. The UI installs it through a file: dependency; bun.lock regenerated by bun install. The adapter brings its own @holochain/client ^0.21, installed nested; the UI keeps ^0.20 until the Holochain 0.7 layer. Closes #153
… stream Building inside a full hREA checkout fails under npm 11 (EUNSUPPORTEDPROTOCOL on the workspace link: dependency), so the recipe now extracts the module with git archive. A rebuild reproduces the tar stream, not the gzip layer, so the README records the tar stream sha256 and points at h-REA/hREA#421 for the pack script.
The integration strategy said hREA integration bypasses GraphQL entirely, while this branch vendors the GraphQL adapter into the UI. State the bound: the adapter serves read-only queries, and every write stays zome-level so governance evaluation and PPR issuance cannot be skipped.
Soushi888
force-pushed
the
chore/153-vendor-hrea-adapter
branch
from
October 27, 2026 17:58
fd9c3b6 to
a26ba32
Compare
Soushi888
added a commit
that referenced
this pull request
Oct 27, 2026
…adapter # Conflicts: # bun.lock # ui/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
The UI has no hREA GraphQL adapter yet, and the one that matches hREA
happ-0.5.0-beta.1(0.700.0-rc.0) is not on npm (h-REA/hREA#412). Vendoring the tarball lets the hREA upgrade (#154) and the Holochain 0.7 work (#134) build on it now.Changes
vendor/valueflows-vf-graphql-holochain-0.700.0-rc.0.tgzsits at the top-levelvendor/, beside thevendor/hreasubmodule rather than inside it, and the UI installs it through afile:dependency. Its sha256 (e64163912e87ca2271660806c263e95c8208dfd99a660042bfee5764fba3d2fe) is in the.sha256file next to it. It was built from h-REA/hREA taghapp-0.5.0-beta.1(commit79c8d4fb98c4f7f9a8cf3f7dd69690d6d1334d85,modules/vf-graphql-holochain) and is the same file Requests and Offers vendors.vendor/README.mdgives the rebuild command and how to drop the copy once npm publishes 0.700.bun.lockwas produced bybun install; re-running it from the base plus thisui/package.jsongives an identical lockfile.What this layer cannot do alone
It only installs and type-checks the adapter, and no screen imports it. Adapter 0.700 needs
@holochain/client^0.21 and a Holochain 0.7 conductor, while the UI still pins@holochain/client^0.20 and the hApp runs on 0.6 withvendor/hreaon Sensorica/hREAmain-0.6. So bun installs a second, nested client 0.21.0 under the adapter, and nothing can call hREA through it until #154 and #134 land on top.graphqlresolves only because the adapter hoists 15.8.0; whichever layer first importsgraphqlin UI code should declare it.How to test
The shared-types build and
svelte-kit syncare prerequisites on the base branch too. Measured at48aa2e0: install exits 0, svelte-check 0 errors, server project 1/1. The browser test project was not run locally (Playwright's chromium build is missing on the machine); CI covers it.An independent rebuild of the module extracted outside the hREA workspace (
git archiveof the tag, thennpm install --ignore-scripts,npm run build,npm pack, on node 24.13.0, npm 11.6.2, TypeScript 5.9.3) reproduced the tarball's sha256. That is the recipevendor/README.mdnow gives; it compares the tar stream (gzip -dc <tgz> | sha256sum=fac8a221f0a4c07d643ff43068cf48e8391cad09285c36ea4eb843d1f1d0f00d), because the gzip layer can differ across node/npm builds.Decisions
documentation/hREA/integration-strategy.mdmade hREA integration a Rust/HDK concern that bypasses GraphQL, because governance evaluation and PPR issuance must fire atomically with each economic event. A read fires neither, so querying hREA's ValueFlows graph from the UI is safe, and a mutation through the adapter is out of bounds. Bothintegration-strategy.md(Key Decision and "Why Zome-Level Integration") andvendor/README.mdnow state the bound (a26ba32).vendor/README.mdnames the exit path once npm carries it.Documentation
UI stack documentation updated in
48aa2e0;vendor/README.mdadded.documentation/hREA/integration-strategy.mdbounds the GraphQL path to reads (a26ba32).Pre-open review
Independent pre-open review at
48aa2e0: READY TO OPEN, no blocking finding. Maintainer review then found the original README rebuild recipe fails inside the hREA yarn workspace and overstated reproducibility; fixed infd9c3b6, re-reviewed with the recipe run verbatim: READY. Measured head:fd9c3b6.Re-run 2026-10-27 through PRReview: REQUEST CHANGES on one item, the adapter contradicted the strategy doc's "bypasses GraphQL entirely" decision with no bound stated. Soushi chose to bound it to read-only queries; fixed in
a26ba32with a Decisions block here, and the branch rebased ontodev(808fcd7).bun install --frozen-lockfilepasses. Not superseded:chore/154-hrea-beta1stacks on it, and the hREA beta.1 pin now lands with the Holochain 0.7 port in #130.Related