Repository navigation
asr: bad audio fails the request instead of unloading the model - #190
Merged
Merged
Conversation
uploading something whisper or qwen3-asr can't decode raised inside the worker, which marks it an inference failure and unloads the model. one garbage upload took the model down until someone reloaded it. decode errors now raise AudioDecodeError (a ValueError, so the route returns 400) and the worker fails just that request via packet.request_error. the model stays loaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
send whisper or qwen3-asr a file it can't decode (a webm from a browser, an m4a, whatever) and it throws inside the worker, which counts as an inference failure and unloads the model. one bad upload takes it down until someone reloads it.
decode errors now raise AudioDecodeError, which is a ValueError so the route returns 400, and the worker fails just that request. model stays loaded.
B50, whisper + qwen3-asr loaded, then a webm, an m4a and some junk bytes: