Repository navigation
Conversation
pederbe
marked this pull request as ready for review
September 6, 2026 16:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repeated
fnm installcalls succeed, but their already-installed warning was logged at error level. Log it at info level so it goes to stdout and is suppressed by--log-level errorandquiet.Add shell-matrix regression coverage for output streams, verbosity, successful exit status, and genuine errors. Update the existing warning test and add a patch changeset.
Fixes #1461.
Testing
cargo test --locked: 28 passed.cargo fmt --all --check: passed.cargo clippy --locked --all-targets: passed with warnings in unchanged code.tsc --noEmit: blocked by the existing TS5110 module/moduleResolution mismatch.