Skip to content

Align animation specified-value samples with storage-only identities #840

Description

@wieslawsoltes

Problem

The full-V8 package test webscene_css_property_identity_tests fails because specified_property_samples includes animation-direction, animation-fill-mode, and animation-play-state, while the authoritative metadata intentionally classifies those names as storage-only rather than typed css_property_id entries.

This was exposed by run 35510426945 after the compiler/link blockers were removed. Runtime support for all three properties is present; the failure is an invalid typed-IR coverage claim.

Fix

  • remove storage-only animation properties from the typed specified-value sample catalog;
  • keep their CSSOM exposure and retained runtime behavior unchanged;
  • update the exact typed-sample cardinality assertion;
  • add/retain an explicit check that the three properties remain in the storage-only catalog, so the test cannot silently stop covering their classification.

Acceptance

The focused property identity executable passes, metadata generation stays reproducible, and animation direction/fill/play functionality remains exposed without assigning unstable typed cache identities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingvscode-oss/mergedMerged for the AppScene/WebScene VS Code OSS integration

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions