Skip to content

Restore full-V8 CSS state ordering and MSVC compile depth #828

Description

@wieslawsoltes

Parent: #687. CSS owner: #235. Release coordination: #227.

Problem

Exact native package run 35508413233 exposes ordering and compiler-depth regressions in recently added CSS runtime work: selector_target_cache_entry is declared after the cascade include that consumes it, a removed details-content snapshot still has one call site, several CSS helpers/types lack namespace qualification, and the monolithic style callback exceeds the MSVC block nesting limit.

Scope

  • Move shared selector transition state to the early runtime type layer.
  • Remove the stale details-content transition call consistently with the current retained state model.
  • Qualify CSS property/value helpers and types.
  • Extract nested style branches into bounded helpers so MSVC compiles the translation unit without changing cascade or invalidation behavior.

Acceptance

Full-V8 Linux and Windows package compilers pass the affected translation unit; focused cascade/details/style tests remain reachable and no per-frame cascade or visual-tree work is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingvscode-oss/mergedMerged for the AppScene/WebScene VS Code OSS integration

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions