Skip to content

Repair current V8 API usage in Abort, Range, and Highlight paths #827

Description

@wieslawsoltes

Parent: #687. Release coordination: #227.

Problem

Exact native package run 35508413233 exposes V8 15.3 API portability regressions in recently added AbortSignal, Range, Custom Highlight, animation and DOM code: unavailable Context::GetIsolate, missing external-pointer tags, Data/Value misuse, unqualified helpers, and member calls without a runtime object.

Scope

  • Use the current isolate explicitly in realm helpers.
  • Apply the repository's tagged v8::External contract consistently for Range/Highlight bindings.
  • Use value-shaped internal-field APIs and correct member dispatch.
  • Qualify CSS helpers and pass string data through supported overloads.
  • Preserve validation, weak collection, bounds and production behavior.

Acceptance

The full-V8 Linux and Windows translation units compile without weakening pointer tagging or lifecycle checks, and focused Range/Highlight/Abort/animation contracts remain enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingvscode-oss/mergedMerged for the AppScene/WebScene VS Code OSS integration

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions