Skip to content

Sync with playcanvas/engine main (2026-10-28) - #4

Merged
SashaRX merged 1 commit into
mainfrom
sync/upstream-main
Oct 28, 2026
Merged

SashaRX merged 1 commit into
mainfrom
sync/upstream-main

Conversation

@SashaRX

@SashaRX SashaRX commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Sync with upstream playcanvas/engine main.

1 new commit, range db6f8f84..46233e5b.

Releases / version bumps

  • 46233e5b 2.24.0-beta.24 (package.json / package-lock.json only)

WebGPU, shaders, render passes / render targets, framegraph, breaking changes

  • None in this range.

MSAA / multisampled render targets / resolve (relevant to playcanvas#9167)

  • No upstream commits touch MSAA, multisampled render targets or resolve.

Fork divergence

  • behind_by = 0: fork main has no commits upstream lacks, so this is a fast-forward merge with no conflicts.

Generated by Claude Code

Summary by CodeRabbit

  • Служебные изменения
    • Номер версии пакета обновлён с 2.24.0-beta.23 до 2.24.0-beta.24. Других изменений в этой версии не указано.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T07:38:41.570459Z 46233e5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c7910932-577c-4cee-b4e3-ebb708a89d82
Commits

Reviewing files that changed from the base of the PR and between db6f8f8 and 46233e5.

Files ignored due to path filters: 1
  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 1
  • package.json

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Walkthrough

В package.json версия пакета обновлена с 2.24.0-beta.23 до 2.24.0-beta.24.

Changes

Обновление версии пакета

Layer / File(s) Summary
Версия пакета
package.json
Версия пакета изменена с 2.24.0-beta.23 на 2.24.0-beta.24.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Possibly related PRs

  • SashaRX/engine#3: обновляет версию пакета до 2.24.0-beta.23; этот PR продолжает последовательность обновлений версии.

Suggested reviewers: willeastcott

Merge Risk: Minimal · up to 46233

No actionable merge-blocking risk was identified.

Architecture risk: Low · up to 46233

The change affects 1 system.

Changed systems: package.json

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — package.json (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in package.json: Версия пакета изменена с 2.24.0-beta.23 на 2.24.0-beta.24.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed Заголовок «Sync with playcanvas/engine main (2026-10-28)» описывает основное изменение: синхронизацию main с upstream-репозиторием playcanvas/engine. Согласно pr_objectives, диапазон db6f8f8..46233e5…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

Заголовок «Sync with playcanvas/engine main (2026-10-28)» описывает основное изменение: синхронизацию main с upstream-репозиторием playcanvas/engine. Согласно pr_objectives, диапазон db6f8f8..46233e5 содержит один коммит, который повышает версию пакета до 2.24.0-beta.24 в package.json и package-lock.json. Сводка raw_summary подтверждает изменение версии в package.json с 2.24.0-beta.23 до 2.24.0-beta.24. Заголовок не упоминает версию, поэтому он описывает процесс синхронизации, а не конкретное изменение. Тем не менее заголовок связан с изменениями и не вводит в заблуждение.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

package.json

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

Кролик сверил номер сборки,
В package.json заметил шаг.
Был beta.23 — теперь beta.24,
Записан новый номер в файл.
Морковку грыз — и скачет в сад.

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Build size report

This PR changes the size of the minified bundles.

Bundle Minified Gzip Brotli
playcanvas.min.js 2774.2 KB — 719.1 KB — 557.8 KB (−471 B, −0.08%)
playcanvas.min.mjs 2770.9 KB — 718.1 KB — 557.3 KB (+149 B, +0.03%)

@graphify-labs graphify-labs Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graphify reviewed this change.

No issues found by static checks — no coupling regressions or blocking issues in the code graph. That is not the same as safe to merge: see what was not checked.

Not checked: tests were not run; no formal proof of the changed code.


Graphify review — findings

Bumps the playcanvas package version from 2.24.0-beta.23 to 2.24.0-beta.24 in both package.json and package-lock.json. No dependencies, scripts, exports, or source code change, so this is a version-only release bump for the next beta.

No blocking issues surfaced.

Analysis details — impact, health, verification

Impact & health

Graphify review

Impact — 166 functions depend on the 166 functions this change touches.

Health — grade A; 1 existing hotspot(s) in the area this change touches (pre-existing, not introduced here):

  • keywords — 0 callers, 21 callees (high)

Verification — 166 functions in the blast radius were not formally verified this run (proofs are advisory here).

Gate & verification

graphify gate

PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.

Advisory (not blocking):

  • verification_scope: 166 function(s) in the blast radius were not formally verified this run

@SashaRX
SashaRX merged commit 46233e5 into main Oct 28, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant