Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
A collision node such as
Seat_COLwith its ownM_Wood_Oakmaterial and no matching render sibling received no surface binding. The Colliders step only inspected render siblings, and Apply removed the collision renderer before resolving its surface.Read surface evidence before renderer removal and inspect the node's own materials before matched render siblings. Explicit surface words in the part name still take priority. No game types, assembly dependencies, serialized settings or binding interfaces are added.
Verification
Integration boundaries
Documentation~/PREPARE_SURFACE_BINDING.mddocuments the existing API and limits: a root MeshCollider skips the entire Colliders step, mixed-material nodes receive one surface, a manual binding on a source node is not migrated when its collider moves to root, and missing assets are warnings. These policies are unchanged; this change does not claim to make existing-model migration or per-submesh ballistics complete.